Improve error message #805

Merged
merged 2 commits into from Mar 17, 2013

Conversation

Projects
None yet
3 participants
@tricknotes
Member

tricknotes commented Mar 13, 2013

fixture is an instance of Object.

Before:

the id property must be defined for fixture [Object object]

After:

the id property must be defined for fixture {"foo": "bar"}
Improve error message
`fixture` is an instance of `Object`.

Before:
```
the id property must be defined for fixture [Object object]
```

After:
```
the id property must be defined for fixture {"foo": "bar"}
```
@mbrennan-afa

This comment has been minimized.

Show comment Hide comment
@mbrennan-afa

mbrennan-afa Mar 13, 2013

Something to consider is obviously browser support.
http://caniuse.com/json

This gets my 👍 though

Something to consider is obviously browser support.
http://caniuse.com/json

This gets my 👍 though

@stefanpenner

This comment has been minimized.

Show comment Hide comment
@stefanpenner

stefanpenner Mar 14, 2013

Member

@tricknotes a quick feature sniff + fallback should do the trick.

Member

stefanpenner commented Mar 14, 2013

@tricknotes a quick feature sniff + fallback should do the trick.

@tricknotes

This comment has been minimized.

Show comment Hide comment
@tricknotes

tricknotes Mar 14, 2013

Member

@stefanpenner Okay. I did it.

Member

tricknotes commented Mar 14, 2013

@stefanpenner Okay. I did it.

stefanpenner added a commit that referenced this pull request Mar 17, 2013

@stefanpenner stefanpenner merged commit 830420a into emberjs:master Mar 17, 2013

1 check passed

default The Travis build passed
Details

@tricknotes tricknotes deleted the tricknotes:improve-error-message branch Mar 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment