Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Extract validation errors with correct attribute names #831

merged 1 commit into from Apr 4, 2013


None yet
7 participants

tchak commented Mar 22, 2013

No description provided.


jasonkriss commented Mar 22, 2013

👍 love it.


pangratz commented Mar 23, 2013

nice 👍


stefanpenner commented Mar 24, 2013

@hjdivad thoughts?

igorT added a commit that referenced this pull request Apr 4, 2013

Merge pull request #831 from tchak/validation-errors-fix
Extract validation errors with correct attribute names

@igorT igorT merged commit 6985761 into emberjs:master Apr 4, 2013

1 check failed

default The Travis build failed

bradfol commented Apr 17, 2013

This drops any validation errors that are for relationships. Thoughts on how to deal with that case? Thank you.
@tchak @igorT


bobbus commented Apr 23, 2013

@bradfol, I open a PR to keep errors which do not match an attributes name : #909


tchak commented Apr 23, 2013

@bobbus I am not sure this is such a good idea. At last not in the curent state of error handling. We have no way to clear custom errors.

@tchak tchak deleted the tchak:validation-errors-fix branch Apr 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment