Only attempt to sideload keys with array values #833

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@ahawkins
Contributor

ahawkins commented Mar 22, 2013

No description provided.

@igorT

This comment has been minimized.

Show comment Hide comment
@igorT

igorT Apr 8, 2013

Member

Why does adding ok fix the test? I think in this case we should throw an assert and not silently ignore the key. Do you have a use case for ignoring keys?

Member

igorT commented Apr 8, 2013

Why does adding ok fix the test? I think in this case we should throw an assert and not silently ignore the key. Do you have a use case for ignoring keys?

@ahawkins

This comment has been minimized.

Show comment Hide comment
@ahawkins

ahawkins Apr 8, 2013

Contributor

Why does adding ok fix the test?

I have no clue why. Perhaps it materializes something.

Do you have a use case for ignoring keys?

Some API's return meta data at the root. Here's an example:

{page: 1, total: 5, count: 50, posts: [ ... ]}

On Mon, Apr 8, 2013 at 9:14 AM, Igor Terzic notifications@github.comwrote:

Why does adding ok fix the test? I think in this case we should throw an
assert and not silently ignore the key. Do you have a use case for ignoring
keys?


Reply to this email directly or view it on GitHubhttps://github.com/emberjs/data/pull/833#issuecomment-16035799
.

Contributor

ahawkins commented Apr 8, 2013

Why does adding ok fix the test?

I have no clue why. Perhaps it materializes something.

Do you have a use case for ignoring keys?

Some API's return meta data at the root. Here's an example:

{page: 1, total: 5, count: 50, posts: [ ... ]}

On Mon, Apr 8, 2013 at 9:14 AM, Igor Terzic notifications@github.comwrote:

Why does adding ok fix the test? I think in this case we should throw an
assert and not silently ignore the key. Do you have a use case for ignoring
keys?


Reply to this email directly or view it on GitHubhttps://github.com/emberjs/data/pull/833#issuecomment-16035799
.

@igorT

This comment has been minimized.

Show comment Hide comment
@igorT

igorT Apr 8, 2013

Member

I feel like we would want a more comprehensive solution for this as you could reasonably expect the metadata to be an array as well. Maybe some api for specifying non sideloaded keys or smth? @tomdale ?

Member

igorT commented Apr 8, 2013

I feel like we would want a more comprehensive solution for this as you could reasonably expect the metadata to be an array as well. Maybe some api for specifying non sideloaded keys or smth? @tomdale ?

@igorT

This comment has been minimized.

Show comment Hide comment
@igorT

igorT Apr 8, 2013

Member

I think #815 solves this use case?

Member

igorT commented Apr 8, 2013

I think #815 solves this use case?

@igorT igorT closed this Apr 8, 2013

@igorT

This comment has been minimized.

Show comment Hide comment
@igorT

igorT Apr 11, 2013

Member

#815 has been merged in

Member

igorT commented Apr 11, 2013

#815 has been merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment