Refactor ComponentViewItem to use native class
#1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
force-pushed
the
refactor-component-view-item
branch
from
882c4b4
to
6051dac
Compare
There was a problem hiding this comment.
@chancancode this seems mostly okay, but we have some test failures. Mind taking a look?
| @@ -137,7 +136,7 @@ export default Controller.extend({ | |||
| viewArray.forEach(viewItem => { | |||
| let cachedExpansion = expandedStateCache[getIdFromObj(viewItem)]; | |||
| if (cachedExpansion !== undefined) { | |||
| viewItem.set('expanded', cachedExpansion); | |||
There was a problem hiding this comment.
We not longer need set here?
There was a problem hiding this comment.
The class is using @tracked.
| @@ -210,7 +209,7 @@ export default Controller.extend({ | |||
| this.filteredArray.forEach((item) => { | |||
| const id = getIdFromObj(item); | |||
| if (objects.includes(id)) { | |||
| item.set('expanded', state); | |||
wycats
force-pushed
the
refactor-component-view-item
branch
from
6051dac
to
b7e0cc3
Compare
RobbieTheWagner
approved these changes
Nov 9, 2019
|
@chancancode this seems fine to me, we just need to fix the tests. |
|
Yeah! I looked into it and I know why it's not working. It needs a bigger refactor, I'll get back to this next week. |
nummi
approved these changes
Nov 9, 2019
|
I’ll resubmit this as part of a bigger refactor to use the new debug render tree api. I was hoping that this can be separated out relatively cleanly, but it needed more work that start to eat into the other refactor so probably doesn’t make sense to do it in isolation anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.