From 143ef40d76351b005a08fe5bd644ef6d2f5c6a8a Mon Sep 17 00:00:00 2001
From: Geordan Neukum <gneukum1@gmail.com>
Date: Sun, 24 Apr 2022 12:38:16 -0400
Subject: [PATCH] deprecations: fixup instances of no-inline-styles

ember-template-lint's no-inline-styles rule forbids using inline styles
as they are often harder to maintain and can make the overall size of
the project bigger. It recommends using css classes instead.

Let's fixup any instances of this issue in the codebase and then
re-enable the rule in our template-lintrc so that the linter will help
us avoid adding more instances of this in the future.
---
 .template-lintrc.js            | 1 -
 app/styles/deprecations.scss   | 4 ++++
 app/templates/deprecations.hbs | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.template-lintrc.js b/.template-lintrc.js
index c40a65c117..7ad001219f 100644
--- a/.template-lintrc.js
+++ b/.template-lintrc.js
@@ -9,7 +9,6 @@ module.exports = {
     // TODO: enable these rules
     'no-action': false,
     'no-implicit-this': false,
-    'no-inline-styles': false,
     'no-positive-tabindex': false,
     'table-groups': false,
   },
diff --git a/app/styles/deprecations.scss b/app/styles/deprecations.scss
index 8045ad669d..34374683f7 100644
--- a/app/styles/deprecations.scss
+++ b/app/styles/deprecations.scss
@@ -1,3 +1,7 @@
+.js-deprecations {
+  height: 100%;
+}
+
 .deprecation-item {
   border-bottom: 1px solid var(--base01);
 
diff --git a/app/templates/deprecations.hbs b/app/templates/deprecations.hbs
index 42dfd65769..ae403db486 100644
--- a/app/templates/deprecations.hbs
+++ b/app/templates/deprecations.hbs
@@ -10,7 +10,7 @@
 {{/if}}
 
 {{#if filtered.length}}
-  <div class="list__content js-deprecations" style="height: 100%;">
+  <div class="list__content js-deprecations">
     {{#vertical-collection filtered estimateHeight=20 as |content|}}
       <DeprecationItem
         @model={{content}}