Remove Ember.K. #617

Merged
merged 1 commit into from Nov 20, 2016

Projects

None yet

5 participants

@locks
Contributor
locks commented Nov 20, 2016

No description provided.

app/components/drag-handle.js
-const { computed, String: { htmlSafe }, K } = Ember;
+
+const { computed, String: { htmlSafe } } = Ember;
+const K = function() { return this; }
@rwjblue
rwjblue Nov 20, 2016 Member

IMHO, the replacement here is simply to use empty functions where needed. We don't need another "special" Emberism, let's just use functions.

@stefanpenner
Member

👍

@teddyzeenny

lgtm. Please update the commit message before merging.

app/mixins/row-events.js
@@ -27,7 +27,7 @@ export default Mixin.create({
* @type {Function}
* @default Ember.K
app/mixins/row-events.js
@@ -36,7 +36,7 @@ export default Mixin.create({
* @type {Function}
* @default Ember.K
app/mixins/row-events.js
@@ -45,7 +45,7 @@ export default Mixin.create({
* @type {Function}
* @default Ember.K
app/components/drag-handle.js
@@ -45,7 +47,7 @@ export default Ember.Component.extend({
* @type {Function}
* @default Ember.K
@locks locks Remove `Ember.K` usage
2a5b9ef
@locks locks changed the title from [WIP] Remove Ember.K. to Remove Ember.K. Nov 20, 2016
@locks
Contributor
locks commented Nov 20, 2016

Done!

@teddyzeenny teddyzeenny merged commit e28c918 into master Nov 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@teddyzeenny teddyzeenny deleted the remove-ember-k branch Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment