New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setupTest supporting old and new testing APIs #199

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@simonihmig
Copy link
Contributor

simonihmig commented Mar 5, 2018

Closes #198

@@ -14,11 +14,20 @@ import {
TestModuleForAcceptance
} from 'ember-test-helpers';

const setupTest = setupTestFactory(TestModule);
const setupTestOld = setupTestFactory(TestModule);

This comment has been minimized.

@Turbo87

Turbo87 Mar 5, 2018

Member

can you make sure to export setupTestOld() too? just in case people are actually using this without a string as first arg

This comment has been minimized.

@simonihmig

simonihmig Mar 6, 2018

Contributor

Done. Called it setupTestLegacy, agree?

This comment has been minimized.

@Turbo87

Turbo87 Mar 6, 2018

Member

we're sort of running into a trap here since the old-old thing is already called old, but I'm okay with that for now... 🙈

This comment has been minimized.

@rwjblue

@simonihmig simonihmig force-pushed the simonihmig:setuptest branch from 08be15c to 9078171 Mar 6, 2018

@Turbo87

Turbo87 approved these changes Mar 6, 2018

Copy link
Member

Turbo87 left a comment

looks great, thanks a lot! 💪

CI seems unhappy though... 🤔

@Turbo87

This comment has been minimized.

Copy link
Member

Turbo87 commented Mar 6, 2018

I restarted the failed CI run (timeout) and it passed now 🎉

@Turbo87 Turbo87 merged commit 534f587 into emberjs:master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simonihmig simonihmig deleted the simonihmig:setuptest branch Mar 6, 2018

@Turbo87 Turbo87 added the enhancement label Mar 15, 2018

@simonihmig simonihmig referenced this pull request Aug 21, 2018

Merged

[ember-mocha] Update typings for ember-mocha 0.14 #28272

7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment