Submodules

[joliss]

I actually just a few minutes ago needed to poke into the Ember code that was running inside my Rails app, so it was easiest to change ember-rails app to rebuild its assets from the sources. (And it's working great.) Here's the patch.

Fixes #4 (see also my comments there for some background) and #22.

[alexrothenberg]

I'm happy if this replaces my pull request #23 but I

I don't know enough about git submodules to know if this will grab the latest ember and ember-data but it looks like specific SHAs are checked in.

Also I think this will build against the head of both which may be an unpublished version. Is there a way to make it checkout a published tag of ember and ember-rails before building? Ideally we should not have to build ember or ember-data and could just download the published versions but I don't think all the files this gem needs are published.

[joliss]

Yes, specific SHAs are checked in. It will not grab the latest ember/ember-data unless you cd into the submodule and check out the master branch. Updating the repo works like this.

Is there a way to make it checkout a published tag of ember and ember-rails before building?

You can check out whatever tag you want with git (git checkout v0.9.7.1 in the submodule).

[joliss]

This PR no longer deletes the vendor files, since that would make it impossible to use gem 'ember-rails', git: 'https://github.com/emberjs/ember-rails'.

[joliss]

I still have this in my working copy, by the way, and it's been really useful for writing up pull requests, like emberjs/ember.js#760 or even emberjs/ember.js#793 (I was able to sprinkle console.log calls into the Ember source while running my app against it, which helped me understand the source I was documenting).

[joliss]

Is there still any interest in this? It would need updating for master, but I'll probably abandon this unless there's some consensus that this should be merged.