Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Generator generates `integer` and `datetime` data types. #83

Closed
mrrooijen opened this Issue Aug 9, 2012 · 3 comments

Comments

Projects
None yet
4 participants

Shouldn't this be number and date? If I use the provided integer and datetime I get a bunch of errors. Changing them to number and date removes the errors.

Owner

stefanpenner commented Aug 10, 2012

Correct, number and date exist in-place of integer + datetime.

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/model/attributes.js#L115
https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/model/attributes.js#L95

Your could theoretically add some sort of datetime support via https://github.com/capitainetrain/ember-addons/tree/master/packages/ember-datetime

Anyways, this is clearly broken. I'll have time to submit a patch tomorrow afternoon (unless someone beats me to it)

Member

bradleypriest commented Aug 10, 2012

Whilst you're at it, if you generate a column without a type it should default to string, like Rails.
rails g model Post name generates DS.attr('')

Owner

stefanpenner commented Aug 12, 2012

PR which fixes this -> #84

@tchak tchak closed this in 8e2e339 Aug 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment