refactor handlebars pre-compilation support #30

Merged
merged 7 commits into from Apr 9, 2012

Conversation

Projects
None yet
2 participants
@tchak
Member

tchak commented Apr 5, 2012

  • expose options for handlebars templates (template_root and template_path)
  • allow .hbs extension for templates
@dgeb

View changes

README.md
@@ -10,7 +10,7 @@ You can see an example of how to use the gem [here](https://github.com/keithpitt
Add the gem to your application Gemfile:
- gem "ember-rails"
+ gem "ember_rails"

This comment has been minimized.

Show comment Hide comment
@dgeb

dgeb Apr 6, 2012

Member

@tchak - why the name change here?

@dgeb

dgeb Apr 6, 2012

Member

@tchak - why the name change here?

This comment has been minimized.

Show comment Hide comment
@tchak

tchak Apr 6, 2012

Member

because "_" is ruby default. I aliased the name as "ember-rails" so if you like you can still require "ember-rails"
If this is something that shocks people I will revert :)

@tchak

tchak Apr 6, 2012

Member

because "_" is ruby default. I aliased the name as "ember-rails" so if you like you can still require "ember-rails"
If this is something that shocks people I will revert :)

This comment has been minimized.

Show comment Hide comment
@dgeb

dgeb Apr 6, 2012

Member

I agree in general about underscores, with the exception that dashes are typically used when gems are variants or extensions of one project. This is explained in this post and discussed here and is followed for gems such as coffee-rails, jquery-rails, rspec-rails, etc.

So, I wouldn't go so far as "shocking", just mildly surprising with no reason to change :)

@dgeb

dgeb Apr 6, 2012

Member

I agree in general about underscores, with the exception that dashes are typically used when gems are variants or extensions of one project. This is explained in this post and discussed here and is followed for gems such as coffee-rails, jquery-rails, rspec-rails, etc.

So, I wouldn't go so far as "shocking", just mildly surprising with no reason to change :)

This comment has been minimized.

Show comment Hide comment
@tchak

tchak Apr 6, 2012

Member

ok my bad, will revert it :)

@tchak

tchak Apr 6, 2012

Member

ok my bad, will revert it :)

This comment has been minimized.

Show comment Hide comment
@tchak

tchak Apr 6, 2012

Member

oh and to be clear, I was not trying to change gem name (this was badly reflected by erroneous change to README). I juste wanted to change the default require.

gem 'ember-rails'

require 'ember_rails'

@tchak

tchak Apr 6, 2012

Member

oh and to be clear, I was not trying to change gem name (this was badly reflected by erroneous change to README). I juste wanted to change the default require.

gem 'ember-rails'

require 'ember_rails'

@tchak

This comment has been minimized.

Show comment Hide comment
@tchak

tchak Apr 6, 2012

Member

Reverted some breaking changes. Now behavior of gem is iso with the old one

Member

tchak commented Apr 6, 2012

Reverted some breaking changes. Now behavior of gem is iso with the old one

tchak added a commit that referenced this pull request Apr 9, 2012

Merge pull request #30 from tchak/handlebars
* refactor handlebars pre-compilation support
* move to Ember namespace

@tchak tchak merged commit 736a4d1 into emberjs:master Apr 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment