Permalink
Switch branches/tags
Commits on Apr 27, 2017
  1. Post release version bump.

    rwjblue committed Apr 27, 2017
  2. Add 2.14.0-beta.1 to the CHANGELOG.

    [ci skip]
    rwjblue committed Apr 27, 2017
  3. Merge pull request #15129 from dnachev/service-document-engine-fix

    Fix access to service:-document in ember-engines
    rwjblue committed on GitHub Apr 27, 2017
  4. Add 2.12.2 to CHANGELOG.md.

    [ci skip]
    rwjblue committed Apr 27, 2017
  5. Merge pull request #15183 from rwjblue/update-deps

    Update dependencies to the latest versions within range.
    stefanpenner committed on GitHub Apr 27, 2017
  6. Add 2.13.0-beta.2 to CHANGELOG.

    [ci skip]
    rwjblue committed Apr 7, 2017
  7. Add 2.12.1 to CHANGELOG.md.

    [ci skip]
    rwjblue committed Apr 7, 2017
  8. Lock testem down to 1.15.0.

    rwjblue committed Apr 27, 2017
  9. Merge pull request #15182 from rwjblue/cleanup-features

    Cleanup feature flagging for enabled features.
    rwjblue committed on GitHub Apr 27, 2017
  10. Update dependencies to the latest versions within range.

    Most of these were already allowed via our `package.json`, but I also
    wanted to update the `yarn.lock`.
    
    This pulls in some goodies from `rsvp`, `route-recognizer`, `babel`,
    `dag-map`, and more...
    rwjblue committed Apr 27, 2017
  11. Merge pull request #15181 from rwjblue/cleanup-no-double-extend

    [FEATURE ember-no-double-extend] Remove feature flagging and cleanup.
    rwjblue committed on GitHub Apr 27, 2017
  12. Merge pull request #15180 from rwjblue/update-until-for-container

    [BUGFIX release] Correct `until` values for `this.container` deprecations.
    rwjblue committed on GitHub Apr 27, 2017
  13. Remove usage of `LOOKUP_FACTORY`.

    This was added as a "backdoor" to use `container.lookupFactory`
    (and its double extend semantics) without triggering a deprecation.
    rwjblue committed Apr 27, 2017
  14. Remove `FACTORY_FOR` symbol.

    `FACTORY_FOR` was created as a way to internally use the new `.factoryFor`
    system, and not worry if `no-double-extend` feature was enabled or disabled.
    
    Now that `ember-no-double-extend` is removed, this can also be removed and
    all codepaths that were calling it should now just use `.factoryFor` instead.
    rwjblue committed Apr 27, 2017
  15. Merge pull request #15177 from rwjblue/take-two-dont-mutate-own-prope…

    …rties
    
    [BUGFIX beta] Avoid creating enumerable properties on all objects created by DI.
    rwjblue committed on GitHub Apr 27, 2017
  16. [BUGFIX release] Correct `until` values for `this.container` deprecat…

    …ions.
    
    These deprecations were added in the Ember 2.3 cycle, before we had established
    the LTS system and how private API deprecations are handled. Per the rules
    we created around private API deprecations, the `until` value is supposed to be
    the version just after the next LTS. In theory, that means this could have been
    2.5.0 originally, but I'm updating to 2.13.0 because 2.12 was also an LTS.
    
    An emberobserver.com search shows little usage (other than fallbacks when owner
    is not found), and very few issues are still open around this sort of `.container`
    deprecation.
    rwjblue committed Apr 27, 2017
  17. [BUGFIX beta] Avoid creating enumerable properties on all objects cre…

    …ated by DI.
    
    Prior to these changes, every object created via `owner.factoryFor(...).create()`
    was populated with `NAME_KEY`, `_debugContainerKey`, and `OWNER`.
    
    After these changes:
    
    * For `Ember.Object`'s, only actual injections are included in the create arguments.
    * For non-`Ember.Object`'s, only `OWNER` is included in the create arguments.
    
    `OWNER` is still provided for non-`Ember.Object`'s in order to support various
    classes that are used in the rendering layer that expect to be passed `options[OWNER]`
    so they can function properly. Examples are `ember-glimmer/environment` and
    `ember-glimmer/template`. These should be refactored away from `OWNER` being passed
    in, and this fallback should be removed.
    
    A handful of tests were added / updated. In some cases `_debugContainerKey` assertions
    were removed, since this is no longer supported configuration (e.g. there is no way to
    inject `_debugContainerKey` onto the class itself without double extend).
    rwjblue committed Apr 26, 2017
  18. Merge pull request #15178 from rwjblue/lookup-controllers-for-_qp

    Refactor route to lookup controller for QPs.
    rwjblue committed on GitHub Apr 27, 2017
  19. Refactor route to lookup controller for QPs.

    Previously, the `_qp` computed property attempted to access properties
    off of the `definedControllerClass.proto()`. We even specifically intended
    to support accessing other computed properties or injected services to
    share query param values on. Unfortunately, this entire system relied on
    the old (and deprecated) double extend that was done by `lookupFactory`
    (because CPs and service injections all may need access to injections like
    `owner`). When `ember-no-double-extend` was introduced a "backdoor" was
    added to allow `Route#_qp` to use a non-deprecated version of
    `.lookupFactory`.
    
    The original version of `_qp` used `ResolvedController.proto()` as a
    performance optimization (to prevent extra instantiation and whatnot),
    but at this point using the legacy double extend mechanism and relying
    on `.proto()` is causing more trouble than its worth.
    
    This change, makes accessing `_qp` instantiate the controller instances
    (without the costly double extend), and simply accesses values on them.
    Ultimately, this will force controllers to be instantiated earlier than
    previously (though there were no guarantees on _when_ they would be
    instantiated). This instantiation _should_ be cheaper than forcing the
    double extend for these controllers, and it makes `_qp` much less brittle
    since it is now using a standard public API.
    rwjblue committed Apr 27, 2017
Commits on Apr 26, 2017
  1. Merge pull request #15169 from emberjs/avoid-extra-meta-lookup

    [BUGFIX Beta] [PERF] avoid extra `meta` lookup in constructor
    stefanpenner committed on GitHub Apr 26, 2017
Commits on Apr 25, 2017
  1. Merge pull request #15148 from alexspeller/query-params-refreshModel-…

    …replace-failing-test
    
    Add failing test for query params replace and refreshModel not working together
    rwjblue committed on GitHub Apr 25, 2017
  2. Merge pull request #15168 from cibernox/bum-router-js

    [BUGFIX] Retry transition created with `replaceWith` causes a history replacement
    rwjblue committed on GitHub Apr 25, 2017
  3. [BUGFIX] Retry transition created with `replaceWith` causes a state r…

    …eplacement
    
    This issue was fixed upstream in router.js, I'm just repeating the information here
    for context.
    Before this change the next code:
    
    ```js
    let transition = this.replaceWith('new.route')
    transition.abort()
    transition.retry();
    ```
    
    caused the app to transition to `'new.route'` without replacing the previous history entry.
    After this change, `Transition#retry` respects the intention of the original transition. In
    the snippet above `'new.route'` will now replace the previous route in the history.
    cibernox committed Apr 25, 2017
  4. Merge pull request #15161 from mk-conn/ie-issue-15154

    resolves #15154
    locks committed on GitHub Apr 25, 2017
Commits on Apr 24, 2017
  1. [BUGFIX release] Fixes #15154

    Usage of `Array#includes` is not supported by IE11.
    Krueger, Marko committed with locks Apr 24, 2017
  2. Merge pull request #15162 from emberjs/cp-14947

    CherryPick tests from 14947
    stefanpenner committed on GitHub Apr 24, 2017
  3. Merge pull request #15150 from emberjs/cleanup-proxy

    [BUGFIX beta] [PERF] Cleanup Proxy
    stefanpenner committed on GitHub Apr 24, 2017
  4. Merge pull request #15163 from rwjblue/avoid-leaking-container

    [BUGFIX beta] Avoid storing container on the prototype.
    rwjblue committed on GitHub Apr 24, 2017