New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `Ember.deprecate` and `Ember.warn` calls to include required options. #11835

Closed
rwjblue opened this Issue Jul 21, 2015 · 14 comments

Comments

Projects
None yet
8 participants
@rwjblue
Member

rwjblue commented Jul 21, 2015

This is needed for full implementation of emberjs/rfcs#65 which is being implemented in #11833.

Criteria for both Ember.deprecate and Ember.warn:

  • Add options hash to all calls to Ember.deprecate.
  • Add id property to options hash. The id property is comprised of the package name, and a short code for the deprecation. i.e. ember-view.core-view.

Additional criteria for Ember.deprecate:

  • Add until property to options hash. The until property should be the string value of the Ember version that the behavior being deprecated will be removed in. This can be defaulted to "3.0.0" in the initial PR, and subsequently updated during review.

Work list:

  • packages/container -- 5
  • packages/ember -- 1
  • packages/ember-application -- 5
  • packages/ember-debug -- 43 (might include a bunch of tests for Ember.deprecate itself)
  • packages/ember-htmlbars -- 28
  • packages/ember-metal -- 18
  • packages/ember-routing -- 6
  • packages/ember-routing-views -- 1
  • packages/ember-runtime -- 8
  • packages/ember-template-compiler -- 8
  • packages/ember-testing -- 1
  • packages/ember-views -- 26

If you can commit to updating a given package in the next day or two, please comment below claiming the package that you are working on. When ready, please submit a PR with [DOC beta] prefix and comment below with that PR number.

Follow-up steps:

  • Make options.id and options.until required for Ember.deprecate. This can be done once all calling locations for Ember.deprecate are updated to provide these options.
  • Make options.id required for Ember.warn. This can be done once all calling locations for Ember.warn are updated to provide these options.

@rwjblue rwjblue changed the title from Add `id` and `until` to all `Ember.deprecate` calls. to Update `Ember.deprecate` and `Ember.warn` calls to include required options. Jul 21, 2015

@pixelhandler

This comment has been minimized.

Show comment
Hide comment
@pixelhandler

pixelhandler Jul 21, 2015

Contributor

@rwjblue I can commit to whatever is needed and work all day Friday on it. How about the packages/ember-views am happy to help.

Contributor

pixelhandler commented Jul 21, 2015

@rwjblue I can commit to whatever is needed and work all day Friday on it. How about the packages/ember-views am happy to help.

@EricSchank

This comment has been minimized.

Show comment
Hide comment
@EricSchank

EricSchank Jul 21, 2015

Contributor

I'll take packages/ember and packages/ember-application

Contributor

EricSchank commented Jul 21, 2015

I'll take packages/ember and packages/ember-application

@karthiicksiva

This comment has been minimized.

Show comment
Hide comment
@karthiicksiva

karthiicksiva Jul 21, 2015

Contributor

I am ready to work on packages/ember-routing

Contributor

karthiicksiva commented Jul 21, 2015

I am ready to work on packages/ember-routing

EricSchank added a commit to EricSchank/ember.js that referenced this issue Jul 21, 2015

@max

This comment has been minimized.

Show comment
Hide comment
@max

max Jul 21, 2015

I can take packages/ember-testing.

max commented Jul 21, 2015

I can take packages/ember-testing.

max added a commit to max/ember.js that referenced this issue Jul 21, 2015

Refs emberjs#11835
Include required options for occurences of `Ember.warn` in
`packages/ember-testing`

EricSchank added a commit to EricSchank/ember.js that referenced this issue Jul 21, 2015

[DOC beta] Refs emberjs#11835 - Update packages/ember-application so …
…Ember.deprecate includes required options.
@max

This comment has been minimized.

Show comment
Hide comment
@max

max Jul 21, 2015

packages/ember-testing: #11836

max commented Jul 21, 2015

packages/ember-testing: #11836

EricSchank added a commit to EricSchank/ember.js that referenced this issue Jul 21, 2015

[DOC beta] Refs emberjs#11835 - Update packages/ember-application/lib…
…/utils/validate-type.js so Ember.deprecate includes required options.

max added a commit to max/ember.js that referenced this issue Jul 21, 2015

Refs emberjs#11835 ember-routing-views
Include required options for occurences of `Ember.deprecate` in
`packages/ember-routing-views`
@EricSchank

This comment has been minimized.

Show comment
Hide comment
@EricSchank

EricSchank Jul 21, 2015

Contributor

packages/ember and packages/ember-application : PR #11837

Contributor

EricSchank commented Jul 21, 2015

packages/ember and packages/ember-application : PR #11837

@martndemus

This comment has been minimized.

Show comment
Hide comment
@martndemus

martndemus Jul 21, 2015

Contributor

I did container (#11841), ember-htmlbars (#11840), ember-metal (#1139), ember-routing (#1142).

Contributor

martndemus commented Jul 21, 2015

I did container (#11841), ember-htmlbars (#11840), ember-metal (#1139), ember-routing (#1142).

@Serabe

This comment has been minimized.

Show comment
Hide comment
@Serabe

Serabe Jul 21, 2015

Member

I'll take packages/ember-runtime and packages/ember-template-compiler. #11844

Member

Serabe commented Jul 21, 2015

I'll take packages/ember-runtime and packages/ember-template-compiler. #11844

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jul 21, 2015

Member

Just looked through ember-debug package, and it seems like all usages of Ember.deprecate there are from tests for Ember.deprecate. No updates needed there.

Member

rwjblue commented Jul 21, 2015

Just looked through ember-debug package, and it seems like all usages of Ember.deprecate there are from tests for Ember.deprecate. No updates needed there.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jul 21, 2015

Member

Submitted PR for ember-routing-views: #11847.

Member

rwjblue commented Jul 21, 2015

Submitted PR for ember-routing-views: #11847.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jul 21, 2015

Member

I believe that @SaladFork was going to look into doing ember-views today (I'll circle back with @pixelhandler for more things on his OSS Friday), then we can work on the enforcement items.

Member

rwjblue commented Jul 21, 2015

I believe that @SaladFork was going to look into doing ember-views today (I'll circle back with @pixelhandler for more things on his OSS Friday), then we can work on the enforcement items.

@SaladFork

This comment has been minimized.

Show comment
Hide comment
@SaladFork

SaladFork Jul 21, 2015

Contributor

ember-views: #11848

Contributor

SaladFork commented Jul 21, 2015

ember-views: #11848

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jul 21, 2015

Member

Enforcement added in #11851.

Member

rwjblue commented Jul 21, 2015

Enforcement added in #11851.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jul 21, 2015

Member

It was a pleasure doing business with y'all.

Member

rwjblue commented Jul 21, 2015

It was a pleasure doing business with y'all.

rwjblue added a commit that referenced this issue Jul 24, 2015

Refs #11835
Include required options for occurences of `Ember.warn` in
`packages/ember-testing`

(cherry picked from commit ef5c762)

rwjblue added a commit that referenced this issue Jul 24, 2015

rwjblue added a commit that referenced this issue Jul 24, 2015

[DOC beta] Refs #11835 - Update packages/ember-application so Ember.d…
…eprecate includes required options.

(cherry picked from commit 746d960)

rwjblue added a commit that referenced this issue Jul 24, 2015

[DOC beta] Refs #11835 - Update packages/ember-application/lib/utils/…
…validate-type.js so Ember.deprecate includes required options.

(cherry picked from commit 1f02a38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment