current-when not working with dynamic segment

[amk221]

Here is an example:

https://ember-twiddle.com/93563986146cde7c19cb7e9e985f32c0?openFiles=templates.application.hbs%2C&route=%2Ffoo%2F1

[locks]

@amk221 I don't see any problem, can you please describe your expectation and what's actually happening?

[amk221]

Sure, the hyperlink to foo has current-when='foo.index foo.bar'

Therefore, when I visit foo.bar I am expecting foo to be "current" (because it's current-when attribute contains foo.bar), so the hyperlink should be active. But it is not.

Removing the dynamic segment from the link-to makes it works as expected as per the docs.

[locks]

Ah, it's current-when=['foo.index', 'foo.bar']. Not that I recommend it :P

[amk221]

A couple of questions spring to mind:
Why do you not recommend it?
Why is it not documented?
Why does it work when removing the dynamic segment?

[locks]

Why do you not recommend it?
Why is it not documented?

Because it should ideally be done via route nesting/architecture.

Why does it work when removing the dynamic segment?

I don't know what you mean.

[amk221]

Because it should ideally be done via route nesting/architecture.

If I am doing something ill-advised, can you link me to how I should be doing it?
as far as I can tell, there is nothing complicated or incorrect with the route architecture.

Why does it work when removing the dynamic segment?
I don't know what you mean

I mean, if you remove the number "1" from link-to 'foo' it will work as expected.

[locks]

Oh, you were passing two arguments to a route (foo) that only has one dynamic segment.

[amk221]

:) nope, the arguments are correct.
"/foo/:fooId"
'foo' 'is the title text
'foo' is the route
'1' is the dynamic arg

FWIW even though it's closed, I still think this is a bug

[psteininger]

@amk221 did you ever get around this issue? I am running into the same situation, on a link with 2 dynamic elements /facilities/:facility_id/issues/:issue_id on /facilities/:facility_id/issues it works, but on /facilities/:facility_id/issues/:issue_id it doesn't despite:

{{#link-to 'facility.issues' model current-when='facility.issues facility.issue'}}

the routes are like so:

...
 this.route('facilities', {resetNamespace: true});
    this.route('facility', {resetNamespace: true, path: '/facilities/:facility_id'}, function () {
      ...
      this.route('issues');
      this.route('issue', {path: '/issues/:issue_id'});
    });
...

ignore the resetNamespace:true it deals with being under a protected route

[amk221]

Nope, sorry I managed to write a failing test, but I have no clue as to how and fix it

[psteininger]

@amk221 It looks like the problem sits in the fact that for facility.issue route there need to be 2 models/contexts, but in the link definition there is only 1. I did some debugging and saw that for another link-to (which has both the facility and the issue) the method would have succeeded.

I traced it down to this call:

// file: 'ember-routing/system/router_state' #isActiveIntent
 if (!this.routerJs.isActiveIntent(routeName, models, null, state)) {
        return false;
      }

that returns false

[psteininger]

I think I traced it down to this method:

function handlerInfosEqual(handlerInfos, otherHandlerInfos) {
  if (handlerInfos.length !== otherHandlerInfos.length) {
    return false;
  }

  for (var i = 0, len = handlerInfos.length; i < len; ++i) {
    if (handlerInfos[i] !== otherHandlerInfos[i]) {
      return false;
    }
  }
  return true;
}

The key difference is that there is a _names key with array of params (in this case issue_id)