New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC4 - Slow transitions related to Backburner.js #2750

Closed
workmanw opened this Issue May 28, 2013 · 8 comments

Comments

Projects
None yet
3 participants
@workmanw
Contributor

workmanw commented May 28, 2013

I upgrade to RC4 this morning and discovered immediately that my app is making very slow transitions, in some cases it takes nearly 5000ms to transition.

After a little bit of poking around I discovered the problem seemed to be that my outlet views are being completely destructed, synchronously, before the new outlet views are inserted. My app is spending about 3-4 seconds destroying and cleaning up views.

I ended up using git bisect to track down the problem commit which is 9ed6dcc . It seems that the commit immediately prior to that (9858b19) delays the destruction of my views, while the previously mentioned commit causes them to happen immediately.

I'm not sure what I can do to help solve this problem. I haven't spent anytime looking at Backburner.js. So help me, help you.

@stefanpenner

This comment has been minimized.

Member

stefanpenner commented May 28, 2013

@workmanw this seems bad.

some high level stuff to help:

ping (@ebryn + @kselden) and specific ideas or debugging suggestions.

@workmanw

This comment has been minimized.

Contributor

workmanw commented May 28, 2013

@stefanpenner -- Yea, sure thing. I'm on my way to JSConf presently and my flight doesn't have Wifi. I'll try to get as much in as possible, but then I'll be radio silent for a few hours.

Here are the fiddles. Notice that if you click between "More Views" and "Less Views" the time it takes to transition. Toggle between "More Views" and "Less Views" several times in both fiddles. It seems to be a linear problem, if you increase the view count from 250 to 500 it's more noticeable. Presently, I believe the long transition is due to the fact that views appear to be destructed synchronously, but I could be wrong.

Fiddle w/ 4daa467 that demonstrates the problem: http://jsfiddle.net/DCrHG/35/
Fiddle w/ 9858b19 that works fine: http://jsfiddle.net/DCrHG/37/

@ebryn and @kselden -- What can I do to help here?

@stefanpenner

This comment has been minimized.

Member

stefanpenner commented May 28, 2013

@workmanw fantastic.

@ebryn

This comment has been minimized.

Member

ebryn commented May 28, 2013

Should be fixed by bd1629e.

Interestingly, this is slow in Chrome, but not in Safari/WebKit nightlies.

@stefanpenner

This comment has been minimized.

Member

stefanpenner commented May 28, 2013

@ebryn nice quick response! @workmanw can you confirm this helps?

@workmanw

This comment has been minimized.

Contributor

workmanw commented May 28, 2013

@ebryn Awesome. I'll confirm once I land. Looks like my theory of sync destruction was way off base. Thanks!

@ebryn

This comment has been minimized.

Member

ebryn commented May 28, 2013

Here's an updated fiddle with ember-latest.js: http://jsfiddle.net/DCrHG/38/ Pretty easy to see it's fixed.

@workmanw

This comment has been minimized.

Contributor

workmanw commented May 28, 2013

@ebryn, @stefanpenner -- Confirmed fixed. Thanks guys. Team work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment