Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ember.ObjectController. #10062

Merged
merged 1 commit into from Jan 2, 2015

Conversation

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 28, 2014

  • Deprecate on init of Ember.ObjectController's when not auto-generated.
  • Deprecate on get of a proxied property.
  • Deprecate on set of a proxied property.
@rwjblue rwjblue force-pushed the deprecate-object-controller branch from 1daec3e to 833460b Dec 28, 2014
@mixonic mixonic mentioned this pull request Dec 28, 2014
@rwjblue rwjblue force-pushed the deprecate-object-controller branch from 833460b to 0bca015 Dec 28, 2014
@rwjblue rwjblue force-pushed the deprecate-object-controller branch from 0bca015 to 8b6c8e8 Jan 2, 2015
@rwjblue
Copy link
Member Author

@rwjblue rwjblue commented Jan 2, 2015

Rebased.

Loading

@rwjblue
Copy link
Member Author

@rwjblue rwjblue commented Jan 2, 2015

Submitted PR to Ghost (TryGhost/Ghost#4748) showing the upgrade path. The following are the key upgrade concepts:

  • Update template usage to reference {{model.propertyName}} instead of {{propertyName}}.
  • Update CP and Observer dependent keys to use model.propertyName.
  • Update route and controller access to ensure model.propertyName is used for any get or set operations.

Loading

* Deprecate on `init` of `Ember.ObjectController`'s when not
  auto-generated.
* Deprecate on `get` of a proxied property.
* Deprecate on `set` of a proxied property.
@rwjblue rwjblue force-pushed the deprecate-object-controller branch from 093aeed to 33042d9 Jan 2, 2015
rwjblue added a commit that referenced this issue Jan 2, 2015
@rwjblue rwjblue merged commit 3f78acc into emberjs:master Jan 2, 2015
1 check passed
Loading
@rwjblue rwjblue deleted the deprecate-object-controller branch Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant