Deprecate Ember.ObjectController.#10062
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jan 2, 2015
Merged
Conversation
rwjblue
force-pushed
the
deprecate-object-controller
branch
from
1daec3e to
833460b
Compare
Closed
rwjblue
force-pushed
the
deprecate-object-controller
branch
from
833460b to
0bca015
Compare
rwjblue
force-pushed
the
deprecate-object-controller
branch
from
0bca015 to
8b6c8e8
Compare
Member
Author
|
Rebased. |
Member
Author
|
Submitted PR to Ghost (TryGhost/Ghost#4748) showing the upgrade path. The following are the key upgrade concepts:
|
rwjblue
force-pushed
the
deprecate-object-controller
branch
from
8b6c8e8 to
093aeed
Compare
* Deprecate on `init` of `Ember.ObjectController`'s when not auto-generated. * Deprecate on `get` of a proxied property. * Deprecate on `set` of a proxied property.
rwjblue
force-pushed
the
deprecate-object-controller
branch
from
093aeed to
33042d9
Compare
rwjblue
added a commit
that referenced
this pull request
Jan 2, 2015
Deprecate Ember.ObjectController.
This was referenced Jan 5, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initofEmber.ObjectController's when not auto-generated.getof a proxied property.setof a proxied property.