Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ember.ObjectController. #10062

Merged
merged 1 commit into from Jan 2, 2015

Conversation

@rwjblue
Copy link
Member

commented Dec 28, 2014

  • Deprecate on init of Ember.ObjectController's when not auto-generated.
  • Deprecate on get of a proxied property.
  • Deprecate on set of a proxied property.

@rwjblue rwjblue force-pushed the rwjblue:deprecate-object-controller branch Dec 28, 2014

@mixonic mixonic referenced this pull request Dec 28, 2014

@rwjblue rwjblue force-pushed the rwjblue:deprecate-object-controller branch Dec 28, 2014

@rwjblue rwjblue force-pushed the rwjblue:deprecate-object-controller branch Jan 2, 2015

@rwjblue

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2015

Rebased.

@rwjblue

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2015

Submitted PR to Ghost (TryGhost/Ghost#4748) showing the upgrade path. The following are the key upgrade concepts:

  • Update template usage to reference {{model.propertyName}} instead of {{propertyName}}.
  • Update CP and Observer dependent keys to use model.propertyName.
  • Update route and controller access to ensure model.propertyName is used for any get or set operations.

@rwjblue rwjblue force-pushed the rwjblue:deprecate-object-controller branch Jan 2, 2015

Deprecate Ember.ObjectController.
* Deprecate on `init` of `Ember.ObjectController`'s when not
  auto-generated.
* Deprecate on `get` of a proxied property.
* Deprecate on `set` of a proxied property.

@rwjblue rwjblue force-pushed the rwjblue:deprecate-object-controller branch to 33042d9 Jan 2, 2015

rwjblue added a commit that referenced this pull request Jan 2, 2015

@rwjblue rwjblue merged commit 3f78acc into emberjs:master Jan 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rwjblue rwjblue deleted the rwjblue:deprecate-object-controller branch Jan 2, 2015

@SphtKr SphtKr referenced this pull request Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.