New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call transitionEvent for each nested state - Fixes #977 #1059

Merged
merged 3 commits into from Jun 25, 2012

Conversation

Projects
None yet
4 participants
@wagenet
Member

wagenet commented Jun 23, 2012

This could probably use a few more tests, but it does fix the bug and also improves some related behavior.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jun 23, 2012

This pull request passes (merged 260b1b4 into 84e9626).

travisbot commented Jun 23, 2012

This pull request passes (merged 260b1b4 into 84e9626).

@rlivsey

This comment has been minimized.

Show comment
Hide comment
@rlivsey

rlivsey Jun 25, 2012

Contributor

This seems to work fine for a while but then occasionally gets "stuck" where connectOutlets doesn't get called anymore. I'll see if I can figure out what's going on.

Contributor

rlivsey commented Jun 25, 2012

This seems to work fine for a while but then occasionally gets "stuck" where connectOutlets doesn't get called anymore. I'll see if I can figure out what's going on.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jun 25, 2012

This pull request passes (merged 3d55878 into 84e9626).

travisbot commented Jun 25, 2012

This pull request passes (merged 3d55878 into 84e9626).

@rlivsey

This comment has been minimized.

Show comment
Hide comment
@rlivsey

rlivsey Jun 25, 2012

Contributor

Just given this a whirl in my app and it's looking great.

Contributor

rlivsey commented Jun 25, 2012

Just given this a whirl in my app and it's looking great.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jun 25, 2012

This pull request passes (merged b68f05ef into 84e9626).

travisbot commented Jun 25, 2012

This pull request passes (merged b68f05ef into 84e9626).

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Jun 25, 2012

Member

This may not catch every case but it should at least make things better rather than worse :)

Member

wagenet commented Jun 25, 2012

This may not catch every case but it should at least make things better rather than worse :)

wagenet added a commit that referenced this pull request Jun 25, 2012

Merge pull request #1059 from wagenet/setup-contexts-fix
Call transitionEvent for each nested state - Fixes #977

@wagenet wagenet merged commit ebb820b into emberjs:master Jun 25, 2012

@wagenet wagenet referenced this pull request Jun 25, 2012

Closed

Router #997

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jun 25, 2012

This pull request passes (merged 9d82473 into 857a614).

travisbot commented Jun 25, 2012

This pull request passes (merged 9d82473 into 857a614).

@bradleypriest

This comment has been minimized.

Show comment
Hide comment
@bradleypriest

bradleypriest Jun 28, 2012

Member

@wagenet This name variable doesn't seem to exist anywhere before here?

Edit: Looks like it should be 'path'

Member

bradleypriest commented on packages/ember-states/lib/state_manager.js in 9d82473 Jun 28, 2012

@wagenet This name variable doesn't seem to exist anywhere before here?

Edit: Looks like it should be 'path'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment