Allow bound outlet names #11029

Merged
merged 1 commit into from May 5, 2015

Conversation

Projects
None yet
3 participants
@ef4
Contributor

ef4 commented May 5, 2015

Bound outlet names actually work fine without any additional work. They
were just disallowed due to a very old assert that was introduced back
when we were first standardizing the use of quoted strings to represent
literals.

This drops the assertion and adds a test that shows bound outlet names
work.

Allow bound outlet names
Bound outlet names actually work fine without any additional work. They
were just disallowed due to a very old assert that was introduced back
when we were first standardizing the use of quoted strings to represent
literals.

This drops the assertion and adds a test that shows bound outlet names
work.
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue May 5, 2015

Member

👍

Member

rwjblue commented May 5, 2015

👍

@ef4

This comment has been minimized.

Show comment
Hide comment
@ef4

ef4 May 5, 2015

Contributor

Sauce labs timed out.

Contributor

ef4 commented May 5, 2015

Sauce labs timed out.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue May 5, 2015

Member

Restarted.

Member

rwjblue commented May 5, 2015

Restarted.

rwjblue added a commit that referenced this pull request May 5, 2015

@rwjblue rwjblue merged commit fd0cb35 into emberjs:master May 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@john-kurkowski

This comment has been minimized.

Show comment
Hide comment
@john-kurkowski

john-kurkowski Dec 28, 2015

Does this indicate a breaking change in the 1.x series? {{outlet foo}} used to be equivalent to {{outlet "foo"}}. I'm upgrading an Ember 1.8 app to 1.13 and was lucky I came across this in 1.13's changelog. It gave me a hint why some of my outlets were not rendering at all: they were unquoted and thus assumed bound to some undefined property. The assert would've saved me some time.

Does this indicate a breaking change in the 1.x series? {{outlet foo}} used to be equivalent to {{outlet "foo"}}. I'm upgrading an Ember 1.8 app to 1.13 and was lucky I came across this in 1.13's changelog. It gave me a hint why some of my outlets were not rendering at all: they were unquoted and thus assumed bound to some undefined property. The assert would've saved me some time.

@ef4

This comment has been minimized.

Show comment
Hide comment
@ef4

ef4 Dec 28, 2015

Contributor

I'm pretty sure unquoted outlet names already generated a warning in 1.8, yes?

Contributor

ef4 commented Dec 28, 2015

I'm pretty sure unquoted outlet names already generated a warning in 1.8, yes?

@john-kurkowski

This comment has been minimized.

Show comment
Hide comment
@john-kurkowski

john-kurkowski Dec 29, 2015

I hadn't noticed any warnings then. Quote-less outlet names were officially deprecated in 1.10. I wouldn't have thought that meant removal in the 1.x series though. Worth noting in the changelog? I'm not sure it's this PR per se. At the very least, hope Google leads others with the same issue to here.

I hadn't noticed any warnings then. Quote-less outlet names were officially deprecated in 1.10. I wouldn't have thought that meant removal in the 1.x series though. Worth noting in the changelog? I'm not sure it's this PR per se. At the very least, hope Google leads others with the same issue to here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment