[BUGFIX release] Default {{each}} key to @guid or @item based on type.

[rwjblue]

This PR uses @item as the key when the item being iterated is a string or number, and uses @guid when it is anything else.

This is an attempt at making a better default, to prevent users from having to specify a key= to each {{each}} invocation.

It is absolutely possible, that we will want to revisit this and make specifying key required in the future, but it seems that we should attempt at good defaults before making that decision.

[mmun]

Why not just typeof?

[stefanpenner]

yes, lets just use JS typeof here

[mmun]

Looks good 👍

[KTKate]

yay 👍

[rwjblue]

Update:

• Use normal typeof (instead of Ember.typeOf).
• Added @detect as a new type (makes it much easier to document the default)
• Added API docs saying what the default is.

[mixonic]

I am +1. I've also heard many WAT about the current behavior

[rwjblue]

Updated (hopefully for the last time) to deprecate @guid and @item in favor of adding the default of @identity.

[funtusov]

FYI: It seems that this commit didn't get into the 1.13.1 tag

[sandstrom]

Thanks!! ⛵