New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy helper versions. #11900

Merged
merged 7 commits into from Jul 26, 2015

Conversation

Projects
None yet
1 participant
@rwjblue
Member

rwjblue commented Jul 26, 2015

This PR deprecates the following in favor of using Ember.Helper style helpers:

  • Ember.Handlebars.makeViewHelper
  • Ember.HTMLBars.makeViewHelper
  • Ember.HTMLBars._registerHelper
  • Ember.HTMLBars.makeBoundHelper
  • Ember.Handlebars.makeBoundHelper
  • Ember.Handlebars.registerBoundHelper
  • Ember.Handlebars.helper
  • Ember.Handlebars.registerHelper

Based on usage "in the wild" Ember.HTMLBars.makeBoundHelper should be kept around until 3.0.0 (but is deprecated).

Adds deprecations needed for #11858.

/cc @mixonic

rwjblue added some commits Jul 25, 2015

rwjblue added a commit that referenced this pull request Jul 26, 2015

@rwjblue rwjblue merged commit 68719dd into emberjs:master Jul 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue deleted the rwjblue:deprecate-various-helpery-things branch Jul 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment