New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routable components: step one #11939

Merged
merged 1 commit into from Aug 2, 2015

Conversation

Projects
None yet
2 participants
@ebryn
Member

ebryn commented Jul 31, 2015

@ef4 @rwjblue @mmun

I consider this a MVP of the Routable Components RFC.

Things of note:

  • Our current strategy for avoiding naming collisions with existing components is to require routable components to be GlimmerComponents (isGlimmerComponent flag checks). Upon completion of the glimmer-component branch, the tests should be updated to use the new base class.
  • This punts on the creation of the Route#attrs hook for now. These routable components just get created with an attrs hash containing model.

@ebryn ebryn changed the title from Routable components to Routable components: step one Jul 31, 2015

let componentName = options && options.component || namePassed && name || route.componentName || name;
let componentLookup = route.container.lookup('component-lookup:main');
Component = componentLookup.lookupFactory(componentName);
let isGlimmerComponent = Component && Component.proto().isGlimmerComponent;

This comment has been minimized.

@rwjblue

rwjblue Aug 1, 2015

Member

I'd prefer to do Component.isGlimmerComponentFactory (and do Ember.GlimmerComponent.reopenClass({ isGlimmerComponentFactory: true});) over Component.proto().

@rwjblue

rwjblue Aug 1, 2015

Member

I'd prefer to do Component.isGlimmerComponentFactory (and do Ember.GlimmerComponent.reopenClass({ isGlimmerComponentFactory: true});) over Component.proto().

This comment has been minimized.

@ebryn

ebryn Aug 1, 2015

Member

I agree, I was just aligning with the existing glimmer-component branch

@ebryn

ebryn Aug 1, 2015

Member

I agree, I was just aligning with the existing glimmer-component branch

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Aug 1, 2015

Member

I fixed a few issues with Travis (and optional feature tests), can you rebase?

Member

rwjblue commented Aug 1, 2015

I fixed a few issues with Travis (and optional feature tests), can you rebase?

@ebryn

This comment has been minimized.

Show comment
Hide comment
@ebryn

ebryn Aug 1, 2015

Member

Rebased

Member

ebryn commented Aug 1, 2015

Rebased

Show outdated Hide outdated FEATURES.md
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Aug 2, 2015

Member

Looks good, we can merge these incrementally. Can you squash commits and prefix with [FEATURE ember-routing-routable-components]?

Member

rwjblue commented Aug 2, 2015

Looks good, we can merge these incrementally. Can you squash commits and prefix with [FEATURE ember-routing-routable-components]?

@ebryn

This comment has been minimized.

Show comment
Hide comment
@ebryn

ebryn Aug 2, 2015

Member

Done and done

Member

ebryn commented Aug 2, 2015

Done and done

rwjblue added a commit that referenced this pull request Aug 2, 2015

@rwjblue rwjblue merged commit 68cef73 into master Aug 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue deleted the routable-components branch Aug 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment