Routable components: step one #11939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebryn
force-pushed
the
routable-components
branch
from
252866b to
d69b08c
Compare
| let componentName = options && options.component || namePassed && name || route.componentName || name; | ||
| let componentLookup = route.container.lookup('component-lookup:main'); | ||
| Component = componentLookup.lookupFactory(componentName); | ||
| let isGlimmerComponent = Component && Component.proto().isGlimmerComponent; |
There was a problem hiding this comment.
I'd prefer to do Component.isGlimmerComponentFactory (and do Ember.GlimmerComponent.reopenClass({ isGlimmerComponentFactory: true});) over Component.proto().
There was a problem hiding this comment.
I agree, I was just aligning with the existing glimmer-component branch
|
I fixed a few issues with Travis (and optional feature tests), can you rebase? |
ebryn
force-pushed
the
routable-components
branch
from
d69b08c to
b45b466
Compare
|
Rebased |
|
|
||
| * `ember-routing-routable-components` | ||
|
|
||
| TODO |
There was a problem hiding this comment.
Can you link to the RFC here (similar to ember-debug-handlers section).
|
Looks good, we can merge these incrementally. Can you squash commits and prefix with |
… Routable Components
ebryn
force-pushed
the
routable-components
branch
from
b45b466 to
7c8d59a
Compare
|
Done and done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ef4 @rwjblue @mmun
I consider this a MVP of the Routable Components RFC.
Things of note:
GlimmerComponents (isGlimmerComponentflag checks). Upon completion of the glimmer-component branch, the tests should be updated to use the new base class.Route#attrshook for now. These routable components just get created with anattrshash containingmodel.