New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding itemViewClass attribute to the each helper. #1310

Merged
merged 3 commits into from Sep 10, 2012

Conversation

Projects
None yet
5 participants
@txominpelu
Contributor

txominpelu commented Aug 22, 2012

Related to #729

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 22, 2012

This pull request passes (merged 35b2393 into 790fcd5).

travisbot commented Aug 22, 2012

This pull request passes (merged 35b2393 into 790fcd5).

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request passes (merged a599e90 into 790fcd5).

travisbot commented Aug 28, 2012

This pull request passes (merged a599e90 into 790fcd5).

Adding documentation for blockless use of each
Added a description on the documentation on how to use "itemViewClass" with the each helper.
@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request passes (merged ee15ec7 into 790fcd5).

travisbot commented Aug 28, 2012

This pull request passes (merged ee15ec7 into 790fcd5).

@krisselden

This comment has been minimized.

Show comment
Hide comment
@krisselden

krisselden Sep 10, 2012

Member

This seems good to merge, should there be an assert that there is either a block or an itemViewClass?

Member

krisselden commented Sep 10, 2012

This seems good to merge, should there be an assert that there is either a block or an itemViewClass?

@trek

This comment has been minimized.

Show comment
Hide comment
@trek

trek Sep 10, 2012

Member

Thanks for tackling this @txominpelu... it's been an ongoing issue for some time. 👍 for docs too.

Member

trek commented Sep 10, 2012

Thanks for tackling this @txominpelu... it's been an ongoing issue for some time. 👍 for docs too.

@txominpelu

This comment has been minimized.

Show comment
Hide comment
@txominpelu

txominpelu Sep 10, 2012

Contributor

Glad to help @trek ! I'll try to be around helping with other issues.

Contributor

txominpelu commented Sep 10, 2012

Glad to help @trek ! I'll try to be around helping with other issues.

wagenet added a commit that referenced this pull request Sep 10, 2012

Merge pull request #1310 from txominpelu/fixing-729
Adding itemViewClass attribute to the each helper.

@wagenet wagenet merged commit d3efc3c into emberjs:master Sep 10, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment