New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Application#initialize #1317

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@joliss
Contributor

joliss commented Aug 24, 2012

This extracts a bunch of code from init and initialize into separate methods. See the individual commit diffs - they should be more readable than the combined diff.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 24, 2012

This pull request passes (merged 71038729 into 45ad96d).

travisbot commented Aug 24, 2012

This pull request passes (merged 71038729 into 45ad96d).

@joliss joliss referenced this pull request Aug 24, 2012

Closed

Add Application#reset #1318

@wagenet

View changes

Show outdated Hide outdated packages/ember-application/tests/system/application_test.js
@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request passes (merged 65d008f2 into 8532f29).

travisbot commented Aug 28, 2012

This pull request passes (merged 65d008f2 into 8532f29).

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 30, 2012

This pull request passes (merged a681685e into 72b0f3d).

travisbot commented Aug 30, 2012

This pull request passes (merged a681685e into 72b0f3d).

joliss added some commits Aug 23, 2012

Extract runInjections from Application#initialize
This also runs the injections on the newly created router property,
because we collect the keys after adding the router. But this shouldn't
do any harm.

@joliss joliss closed this Sep 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment