New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for globbed routes #1465

Merged
merged 1 commit into from Oct 22, 2012

Conversation

Projects
None yet
4 participants
@gavacho
Contributor

gavacho commented Oct 17, 2012

A naive attempt at addressing #1451. Feedback very much welcomed.

@noirbizarre

This comment has been minimized.

Show comment
Hide comment
@noirbizarre

noirbizarre Oct 18, 2012

It's exactly what I need.
Glad you implented it.
I hope it will be merged soon!

noirbizarre commented Oct 18, 2012

It's exactly what I need.
Glad you implented it.
I hope it will be merged soon!

@wycats

This comment has been minimized.

Show comment
Hide comment
@wycats

wycats Oct 20, 2012

Member

I'd like it if you could use *path and not :*path.

Member

wycats commented Oct 20, 2012

I'd like it if you could use *path and not :*path.

@gavacho

This comment has been minimized.

Show comment
Hide comment
@gavacho

gavacho Oct 20, 2012

Contributor

@wycats I've updated based on your request

Contributor

gavacho commented Oct 20, 2012

@wycats I've updated based on your request

wycats added a commit that referenced this pull request Oct 22, 2012

@wycats wycats merged commit 12f65b7 into emberjs:master Oct 22, 2012

1 check passed

default The Travis build passed
Details
@mdi

This comment has been minimized.

Show comment
Hide comment
@mdi

mdi Sep 7, 2013

It seems to me link-to should handle these optional dynamic segments by not generating an undefined value if one is not present.

mdi commented Sep 7, 2013

It seems to me link-to should handle these optional dynamic segments by not generating an undefined value if one is not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment