Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Public Router service MVP #14805
It includes a minimal API:
Status: Work in progress
How to test drive this PR:
RFC Implementation Phases
referenced this pull request
Jan 13, 2017
This is looking really good! I'm glad you got to the bottom of that
currentURL async issue we chatted about.
I think the only real thing missing here at this point are some tests for
@krisselden I appreciate you wanting to make sure we're focussing on the right things with this PR, in terms of the opportunity to improve the router in general. This intent of this particular PR is to get a useful public API for the router in the hands of devs sooner rather than later. This will help provide immediate value, but does not preclude us circling back and refactoring parts of the internals later. In fact, that's our direct intention. We wanted to try to restrict these changes to simple, surface level changes before we get into the more meaty implementation, specifically the refactoring to use
I'll update the PR's description above to indicate the 4 phases, as discussed by @rwjblue and I.
This is super exciting. Thank you for taking this on and helping driving it home.
One additional thing I'd really like to see fall into one of the later phases is some mechanism for components to subscribe to