New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to support angle bracket invocation. #16686

merged 7 commits into from May 25, 2018


None yet
2 participants

rwjblue commented May 25, 2018

  • Adds feature flag
  • Updates component lookup to allow either hyphenated or names with a capital letter
  • Add AST transform to ensure ...attributes usage is only in element space (and only with the feature flag)
  • Port many of the curly component tests to demonstrate angle bracket invocation works

Stole some code from @chadhietala's branch (after naming mine exactly the same thing and seeing there was a conflict)...

Addressing parts of #16688.

@rwjblue rwjblue force-pushed the rwjblue:angle-bracket-invocation branch from 7e2003b to 0a02903 May 25, 2018

@rwjblue rwjblue force-pushed the rwjblue:angle-bracket-invocation branch from 0a02903 to 647ae44 May 25, 2018

Fixup tests to pass when feature flag is not runtime enableable.
When testing the alpha builds all features are compiled out, but using
`@feature` in the testing harness still thinks the feature will work :(

@rwjblue rwjblue referenced this pull request May 25, 2018


Angle Bracket Invocation Syntax #16688

21 of 21 tasks complete

@rwjblue rwjblue merged commit 1c0fe00 into emberjs:master May 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@rwjblue rwjblue deleted the rwjblue:angle-bracket-invocation branch May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment