Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix instance-initializer-test blueprint for RFC232 #16794

Merged

Conversation

Projects
None yet
3 participants
@stopdropandrew
Copy link
Contributor

commented Jul 5, 2018

instance-initializer tests generated from blueprints fail because the test is attempting to start the application but setupTest hook already has.

Here's an example app with the blueprint and fixed version of the tests: https://github.com/stopdropandrew/ember-fix-instance-initializer-test-blueprint

Fixes #16216

@Exelord

Exelord approved these changes Jul 6, 2018

@rwjblue rwjblue merged commit 2bb2750 into emberjs:master Jul 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue

This comment has been minimized.

Copy link
Member

commented Jul 9, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.