Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] fix mouseEnter/Leave event delegation w/o jQuery #16999

Merged
merged 1 commit into from Sep 23, 2018

Conversation

simonihmig
Copy link
Contributor

@simonihmig simonihmig commented Sep 23, 2018

The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in #16922.

Added better test coverage, with better replication how mouseover/out events fire in reality. The last added tests was the one that catched the misbehaviour.

Related to #16603
Fixes #16922

@rwjblue
Copy link
Member

rwjblue commented Sep 23, 2018

Since #16603 was landed in 3.4 (current release and LTS candidate), we need to update this to [BUGFIX release]. Would you mind updating?

The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in emberjs#16922.

Related to 16603
Fixes emberjs#16922
@simonihmig simonihmig changed the title [BUGFIX beta] fix mouseEnter/Leave event delegation w/o jQuery [BUGFIX release] fix mouseEnter/Leave event delegation w/o jQuery Sep 23, 2018
@simonihmig
Copy link
Contributor Author

@rwjblue sure. I updated the commit message. Targeting the master branch is still correct, right?

@rwjblue
Copy link
Member

rwjblue commented Sep 23, 2018

Yep!

@rwjblue rwjblue merged commit aa83863 into emberjs:master Sep 23, 2018
@simonihmig simonihmig deleted the fix-eventdelegation-nojquery branch September 24, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants