Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Modifier Manager #17143

Merged
merged 4 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@chadhietala
Copy link
Member

chadhietala commented Oct 22, 2018

This is intended to implement RFC#373

chadhietala added some commits Oct 22, 2018

@chadhietala chadhietala force-pushed the modifier-managers branch from 772e868 to 8bc9483 Oct 22, 2018

@chadhietala chadhietala changed the title [WIP] Modifier Manager Modifier Manager Oct 23, 2018

@rwjblue
Copy link
Member

rwjblue left a comment

Overall this looks good, can you add a test for the non-string fallback version of setComponentManager?

@chadhietala chadhietala merged commit dec37c3 into master Oct 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chadhietala chadhietala deleted the modifier-managers branch Oct 23, 2018

@chadhietala chadhietala changed the title Modifier Manager [FEATURE] Modifier Manager Oct 23, 2018

@knownasilya knownasilya referenced this pull request Feb 14, 2019

Open

Modifiers #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.