New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed rollupPackage for Windows #17230

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@MelSumner
Copy link
Contributor

MelSumner commented Nov 26, 2018

Added path.isAbsolute to the rollupPackage function so files will be discovered properly no matter what OS (but in this case, especially Windows).

@MelSumner MelSumner requested a review from rwjblue Nov 26, 2018

@rwjblue rwjblue merged commit 18c3a66 into master Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Nov 26, 2018

Awesome, thanks for working through that!

@rwjblue rwjblue deleted the issue/win-build branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment