Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove deprecated 'POSITIONAL_PARAM_CONFLICT' #17319

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@btecu
Copy link
Contributor

btecu commented Dec 9, 2018

No description provided.

@rwjblue

rwjblue approved these changes Dec 9, 2018

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Dec 9, 2018

Thanks for picking this up @btecu!

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Dec 9, 2018

Looks like a number of legit failures

@btecu btecu force-pushed the btecu:cleanup6 branch 3 times, most recently from fa5d014 to 948e971 Dec 9, 2018

@btecu btecu force-pushed the btecu:cleanup6 branch from 948e971 to f94dd09 Dec 10, 2018

@btecu

This comment has been minimized.

Copy link
Contributor Author

btecu commented Dec 10, 2018

@rwjblue Can you take a look again? I'm not sure if this is the right approach.

@rwjblue
Copy link
Member

rwjblue left a comment

Yep, looks great to me!

@rwjblue rwjblue changed the title Remove deprecated 'POSITIONAL_PARAM_CONFLICT' [CLEANUP] Remove deprecated 'POSITIONAL_PARAM_CONFLICT' Dec 10, 2018

@rwjblue rwjblue merged commit c9e4818 into emberjs:master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.