Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hooks from qunit-rfc-232 util-test blueprint #17340

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@hakubo
Copy link
Contributor

commented Dec 11, 2018

It's not used
so a dev have to delete it by hand after generating a test

@rwjblue
Copy link
Member

left a comment

Seems good to me! I think you will also need to update the test fixtures we use (to fix the failing tests).

@rwjblue rwjblue merged commit 3d7cfff into emberjs:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Awesome, thank you!

@hakubo hakubo deleted the hakubo:patch-1 branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.