Skip to content

Fix to ContainerView to send array mutation notification after it has set up the childViews array in init() #2286

Merged
merged 0 commits into from May 16, 2013

4 participants

@endash
endash commented Mar 17, 2013

See #2283.

Because length is only ever expired as a consequence of a call to arrayContentDidChange, we need to make such a call at the end of init, because length could be calculated before childViews has been set up, and any properties or observers dependent on length will break until a subsequent mutation results in a call to arrayContentDidChange.

@stefanpenner
Ember.js member

@kselden ping

@krisselden krisselden was assigned Mar 20, 2013
@wagenet
Ember.js member
wagenet commented Mar 20, 2013

I talked to @kselden and he expressed concern about this solution. That said, I hope to get his explanation in here for you to see first hand. I don't want to close this without an explanation.

@endash
endash commented Mar 20, 2013

I would definitely appreciate one. I did go back and forth on whether, if the array isn't done initialized yet, if it really 'changed,' but considered that mere semantics.

@stefanpenner stefanpenner merged commit b584940 into emberjs:master May 16, 2013

1 check failed

Details default The Travis CI build failed
@stefanpenner
Ember.js member

i didn't merge this: https://github.com/emberjs/ember.js/commits/master EWUT github?

@endash
endash commented May 16, 2013

I don't think you could have if you wanted to.. I force pushed my fork back to standard ember a little while ago precisely because this stupid commit (on master instead of a branch, d'oh) was giving me merge difficulty. I forgot this PR was even still open.

@stefanpenner
Ember.js member

crazy, ya I was merging unrelated PR's.. crazy. Anyways, I tweeted the issue to @github

@endash
endash commented May 16, 2013

Weird too that the in-line message gives a commit hash but at the top it says "stefanpenner merged 0 commits into emberjs:master from endash:master"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.