WIP: App learns to LOG_ACTIVE_GENERATION #2694

Merged
merged 3 commits into from May 25, 2013

Conversation

Projects
None yet
3 participants
Owner

stefanpenner commented May 19, 2013

logs when controllers/routes are generated.

We likely, should log views as well.

thoughts/feedback would be appreciated.

Contributor

intuitivepixel commented May 19, 2013

Just my five cent's ... IMO it would be awesome if everything that ember "autogenerates" four you would be logged, this would reveal some (more) of the ember "magic" to new framework user.

Member

lukemelia commented May 19, 2013

@intuitivepixel agreed. that's what this PR is going to be

Owner

stefanpenner commented May 19, 2013

Some of the places where the auto generation occurs, isn't really namespace aware, so logging is somewhat dubious, but i agree, the goal should be to provide as much visibility as possible.

Contributor

intuitivepixel commented May 19, 2013

When I started learning ember (and since I'm a "visual" oriented guy) I had thoughts in creating a force directed graph layout dynamically out of the created app, something like this http://getspringy.com/demo.html. And then additionally to the connections showing also the interactions between the components :)
Now seeing work done in this direction reanimates my interest in doing something like this ...
But sincerely I would have doubt where to start. Or is my Idea totally crazy and It would never work out because of the complexity?

Owner

stefanpenner commented May 19, 2013

@intuitivepixel if i understand you correctly, you may want to look at and potentially contribute to https://github.com/tildeio/ember-extension

Contributor

intuitivepixel commented May 19, 2013

@stefanpenner, yeah, I saw Yehuda's presentation of the chrome extension back in January, but forgot completely to look at the code, now I did and it seam's to me that there is exactly the right spot to dig in :)
👍 thank you for the reminder.

Member

lukemelia commented May 20, 2013

Remaining TODO:

  • tests are failing on headless run (likely ember-testing)
  • uber flag to control both LOG_ACTIVE_GENERATION and LOG_VIEW_LOOKUPS. "TELLME"?
  • it would be nice to compile these checks/logging out of production builds

stefanpenner added a commit that referenced this pull request May 25, 2013

Merge pull request #2694 from stefanpenner/log_generation
WIP: App learns to LOG_ACTIVE_GENERATION

@stefanpenner stefanpenner merged commit 89b60c4 into emberjs:master May 25, 2013

1 check passed

default The Travis CI build passed
Details

@stefanpenner stefanpenner deleted the stefanpenner:log_generation branch May 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment