[FEATURE ember-routing-didTransition-hook] Add a didTransition hook to the router.

[mixonic]

For use in analytics and such, you may listen to this hook.

Ember.Application.initializer({
  name: 'analytics',
  initialize: function(container, application){
    var router = container.lookup('router:main');
    router.on('didTransition', function(){
      _gaq.push(['_trackPageview', router.get('url')]);
    });
  }
});

Seems good for analytics, though perhaps you could just observe url directly? I imagine there are other use-cases.

[machty]

this is risky; I think there's a good number of apps that have reopened didTransition (and called _super) to hook into this event. Perhaps the right answer is branching to finalizeTransition within didTransition if the feature flag is enabled? Does didTransition need to be renamed at all?

[mixonic]

Ah, yes. We meant to Em.K the didTransition function so it could still be subclassed. Will update this.

[mixonic]

@machty right you are, there is not need to rename this.

[machty]

a man from my own heart

[gpoitch]

@mixonic how about passing the infos param here?

[mixonic]

@gdub22 looks possible! Out of curiosity, what is in infos that you want access to? What would this enable?

[gpoitch]

@mixonic this same infos that gets passed into the router's didTransition method (line 55). Just a matter of convenience to have that data accessible in the event callback too.

[huafu]

I don’t see this FEATURE in the list of features, neither I can find didTranstion in the doc, is it activated by default now? Or has it been removed?

[mixonic]

@huafu it is in and enabled: https://github.com/mixonic/ember.js/blob/master/packages/ember-routing/lib/system/router.js#L124 The docs are lacking here.

[huafu]

Ok, thanks ;-) So no need for the feature flag anymore :)

Huafu Gandon | gmail (mailto:huafu.gandon@gmail.com) | github (https://github.com/huafu) | linkedin (http://www.linkedin.com/in/pgandon)

On Monday 27 January 2014 at 07:16, Matthew Beale wrote:

@huafu (https://github.com/huafu) it is in and enabled: https://github.com/mixonic/ember.js/blob/master/packages/ember-routing/lib/system/router.js#L124 The docs are lacking here.

—
Reply to this email directly or view it on GitHub (#3452 (comment)).

[rwjblue]

@huafu - Exactly, once the feature is shipped in a a release, we remove it from the FEATURES.md and features.json (as it is always on).

[huafu]

Yes I figured out, but what if you decide to finally remove totally the feature? Where are you keeping track of what feature is integrated when?

Huafu Gandon | gmail (mailto:huafu.gandon@gmail.com) | github (https://github.com/huafu) | linkedin (http://www.linkedin.com/in/pgandon)

On Monday 27 January 2014 at 07:19, Robert Jackson wrote:

@huafu (https://github.com/huafu) - Exactly, once the feature is shipped in a a release, we remove it from the FEATURES.md (http://FEATURES.md) and features.json (as it is always on).

—
Reply to this email directly or view it on GitHub (#3452 (comment)).

[rwjblue]

@huafu - They are tracked in features.json (with descriptions in FEATURES.md) in the root of the main repo. Once a feature is shipped in a release version, the feature flags are removed, and the feature is simply part of the main build.

These might provide more information also:

http://emberjs.com/guides/configuring-ember/feature-flags/
http://emberjs.com/guides/contributing/adding-new-features/

[huafu]

So there is never a feature being abandoned and removed from that?

Huafu Gandon | gmail (mailto:huafu.gandon@gmail.com) | github (https://github.com/huafu) | linkedin (http://www.linkedin.com/in/pgandon)

On Monday 27 January 2014 at 07:43, Robert Jackson wrote:

@huafu (https://github.com/huafu) - They are tracked in features.json (with descriptions in FEATURES.md (http://FEATURES.md)) in the root of the main repo. Once a feature is shipped in a release version, the feature flags are removed, and the feature is simply part of the main build.
These might provide more information also:
http://emberjs.com/guides/configuring-ember/feature-flags/
http://emberjs.com/guides/contributing/adding-new-features/

—
Reply to this email directly or view it on GitHub (#3452 (comment)).

[rwjblue]

Basically no. Once a feature has been enabled and published in the release version (a final non-beta release) it is considered public API and is then bound by the same SemVer requirements as any other piece of the code base.

Up until it is enabled and released, it can be removed (and this has happened once or twice).

[huafu]

Ok, thanks a lot for all those informations

Huafu Gandon | gmail (mailto:huafu.gandon@gmail.com) | github (https://github.com/huafu) | linkedin (http://www.linkedin.com/in/pgandon)

On Monday 27 January 2014 at 07:48, Robert Jackson wrote:

Basically no. Once a feature has been enabled and published in the release version (a final non-beta release) it is considered public API and is then bound by the same SemVer requirements as any other piece of the code base.
Up until it is enabled and released, it can be removed (and this has happened once or twice).

—
Reply to this email directly or view it on GitHub (#3452 (comment)).