Skip to content

[BUGFIX beta] sync router.js #3658

Merged
merged 1 commit into from Oct 28, 2013

5 participants

@machty
Ember.js member
machty commented Oct 28, 2013
  • Sync router.js
  • Don't fire error actions on transitions that have already been aborted/redirected
  • Closes #3162
@machty machty [BUGFIX beta] sync router.js
- Sync router.js
- Don't fire `error` actions on transitions that have already been
  aborted/redirected
- Closes #3162
cf0caa0
@stefanpenner stefanpenner merged commit 7db41bc into emberjs:master Oct 28, 2013

1 check passed

Details default The Travis CI build passed
@nathanhammond

I'll be testing this later today in great depth. :)

@stefanpenner
Ember.js member

@nathanhammond sounds good.

@hjdivad
Ember.js member
hjdivad commented Oct 28, 2013

this also fixes the isNaN issue so you can serialise things like dates.

@pangratz

A new assertion is added, but the expect in this test is not updated. See #3705 for "fixing" this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.