Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 circulare dependencies in ember-metal properties and property_set #5586

Merged
merged 1 commit into from Sep 14, 2014

Conversation

@yonjah
Copy link
Contributor

@yonjah yonjah commented Sep 14, 2014

For the deprecateProperty method we need to have access to the set and get method
but the property_set method also relies on the defineProperty method which is in the same file
I think the good and easy way to solve it is to move deprecateProperty so thats what this fix does.

…r-metal/property_set
rwjblue added a commit that referenced this pull request Sep 14, 2014
ES6 circulare dependencies in ember-metal properties and property_set
@rwjblue rwjblue merged commit e1d388c into emberjs:master Sep 14, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 14, 2014

Thank you!

@trek
Copy link
Member

@trek trek commented Sep 27, 2014

👍 The March Of Progress continues towards ES6ville.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.