Added Ember.ROOT, equal to window if defined, global if defined, otherwise this. Added var ROOT = Ember.ROOT in relevant modules to optimize minification.
This makes it work in nodes. All tests still pass (running rake test[all] and rake test).
added Ember.ROOT, equal to `window` if defined, `global` if defined, …
…otherwise `this`. added var ROOT = Ember.ROOT in relevant modules to optimize minification.
This pull request passes (merged e7d15b8 into f968183).
This pull request passes (merged 9cbbddd into f968183).
Shouldn't this be var ROOT?
It's declared just above. e7d15b8#L3R8
I like this idea, but I think we may want to discuss the implementation a bit more.
This is still on our radar for 1.0 but we've been focusing on some other issues first.
+1 on this feature.
Since it's unlikely that we'll merge in this form I'm closing this PR in favor of #1434. @viatropos, we'll definitely take your work into consideration when we do finally get around to this feature.
I think this is mainly solved by 305202f. If there's more to do, we should make new tickets.