Node support: added Ember.ROOT == window or global or this. #769

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@lancejpollard

Added Ember.ROOT, equal to window if defined, global if defined, otherwise this. Added var ROOT = Ember.ROOT in relevant modules to optimize minification.

This makes it work in nodes. All tests still pass (running rake test[all] and rake test).

lancejpollard added some commits May 1, 2012
@lancejpollard lancejpollard added Ember.ROOT, equal to `window` if defined, `global` if defined, …
…otherwise `this`. added var ROOT = Ember.ROOT in relevant modules to optimize minification.
e7d15b8
@lancejpollard lancejpollard added Ember.ROOT, equal to `window` if defined, `global` if defined, …
…otherwise `this`. added var ROOT = Ember.ROOT in relevant modules to optimize minification.
9cbbddd
@travisbot

This pull request passes (merged e7d15b8 into f968183).

@travisbot

This pull request passes (merged 9cbbddd into f968183).

@devinus

Shouldn't this be var ROOT?

It's declared just above. e7d15b8#L3R8

@wagenet
Member
wagenet commented May 2, 2012

I like this idea, but I think we may want to discuss the implementation a bit more.

@lancejpollard

Any updates?

@wagenet
Member
wagenet commented Jun 21, 2012

This is still on our radar for 1.0 but we've been focusing on some other issues first.

@envone
envone commented Jul 31, 2012

+1 on this feature.

@wagenet
Member
wagenet commented Oct 8, 2012

Since it's unlikely that we'll merge in this form I'm closing this PR in favor of #1434. @viatropos, we'll definitely take your work into consideration when we do finally get around to this feature.

@wagenet wagenet closed this Oct 8, 2012
@wagenet
Member
wagenet commented Oct 19, 2012

I think this is mainly solved by 305202f. If there's more to do, we should make new tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment