GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This is the follow up PR to #747
This PR adds the possibility to define the GitHub credentials for the Rake upload_latest as ENV variables. It also adds a webhook to Travic: a POST to http://emberjs-uploader.herokuapp.com/upload is made. This heroku webapp checks out the latest ember.js from GitHub, does a rake dist and afterwards uploads the builds to the downloads section.
A core contributor needs to clone the pangratz/github-uploader repository, and install the app on heroku as described in the README. The Heroku app should be named emberjs-uploader, as this name is used in the TravicCI webhook.
Add gathering of credentials from ENV
Add webhooks notification
This pull request passes (merged 8bdde59 into 00b8940).
@pangratz I just realized something. Is there any reason to do this in Travis vs as a Github hook?
@wagenet Good question :) Going via Travis has the advantage that the tests have already been executed and the result of the Travis build is POST ed as JSON to the webhook. Using a "normal" Post-receive URL via GitHub services, the tests need to be run too.
What do you think?
Probably ok to have Travis do it, since it ensures that the tests passed.
Merge branch 'master' into add_travisci_webhook
This pull request passes (merged e7157f1 into e2d22aa).
This seems cool. @wagenet Do we have the Heroku app registered?
@ebryn, not yet. If you want to set that up let me know.
Merge pull request #782 from pangratz/add_travisci_webhook
Add TravisCI webhook