Add TravisCI webhook #782

Merged
merged 3 commits into from Jun 3, 2012

Conversation

Projects
None yet
4 participants
Member

pangratz commented May 3, 2012

This is the follow up PR to #747

This PR adds the possibility to define the GitHub credentials for the Rake upload_latest as ENV variables. It also adds a webhook to Travic: a POST to http://emberjs-uploader.herokuapp.com/upload is made. This heroku webapp checks out the latest ember.js from GitHub, does a rake dist and afterwards uploads the builds to the downloads section.

A core contributor needs to clone the pangratz/github-uploader repository, and install the app on heroku as described in the README. The Heroku app should be named emberjs-uploader, as this name is used in the TravicCI webhook.

/cc @wagenet

This pull request passes (merged 8bdde59 into 00b8940).

Owner

wagenet commented May 3, 2012

@pangratz I just realized something. Is there any reason to do this in Travis vs as a Github hook?

Member

pangratz commented May 3, 2012

@wagenet Good question :) Going via Travis has the advantage that the tests have already been executed and the result of the Travis build is POST ed as JSON to the webhook. Using a "normal" Post-receive URL via GitHub services, the tests need to be run too.

What do you think?

Owner

wagenet commented May 3, 2012

Probably ok to have Travis do it, since it ensures that the tests passed.

Merge branch 'master' into add_travisci_webhook
Conflicts:
	Rakefile
	lib/github_uploader.rb

This pull request passes (merged e7157f1 into e2d22aa).

Owner

ebryn commented Jun 2, 2012

This seems cool. @wagenet Do we have the Heroku app registered?

Owner

wagenet commented Jun 3, 2012

@ebryn, not yet. If you want to set that up let me know.

ebryn added a commit that referenced this pull request Jun 3, 2012

@ebryn ebryn merged commit 3a8e8e3 into emberjs:master Jun 3, 2012

@pangratz pangratz deleted the pangratz:add_travisci_webhook branch Nov 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment