Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Re-enable enumerable properties: [], firstObject and lastObject #789

Merged
merged 3 commits into from May 8, 2012

Conversation

Projects
None yet
3 participants
Owner

wagenet commented May 4, 2012

This were previously disabled due to over-zealous firing of firstObject and
lastObject. However, [] was still useful for non-array enumerables.
Additionally, firstObject and lastObject were made smarter so as to only fire
notifications when necessary.

@wagenet wagenet Re-enable enumerable properties: [], firstObject and lastObject
This were previously disabled due to over-zealous firing of firstObject
and lastObject. However, [] was still useful for non-array enumerables.
Additionally, firstObject and lastObject were made smarter so as to only
fire notifications when necessary.
d5e659b

This pull request passes (merged d5e659b into dd1851e).

This pull request passes (merged 9022e60 into dd1851e).

Owner

wagenet commented May 4, 2012

Fixes #420

Owner

wagenet commented May 7, 2012

@wycats, @tomdale, @kselden I would love your feedback on this.

Owner

wagenet commented May 7, 2012

If this all looks good I'll clean up the commits.

Owner

wycats commented May 7, 2012

I'll review this tomorrow. cc @tomdale

@wycats wycats added a commit that referenced this pull request May 8, 2012

@wycats wycats Merge pull request #789 from emberjs/enumerable-observers
Re-enable enumerable properties: [], firstObject and lastObject
026caeb

@wycats wycats merged commit 026caeb into master May 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment