Additional Ember.Binding documentation. #876

Merged
merged 1 commit into from May 25, 2012

Conversation

Projects
None yet
5 participants
@trek
Member

trek commented May 24, 2012

@joliss should just check my spelling and spacing now to save me later embarrassment.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 24, 2012

This pull request passes (merged a00d15e8 into 690e840).

This pull request passes (merged a00d15e8 into 690e840).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 24, 2012

This pull request fails (merged 1b301818 into 690e840).

This pull request fails (merged 1b301818 into 690e840).

@joliss

This comment has been minimized.

Show comment Hide comment
@joliss

joliss May 24, 2012

Contributor

Since you asked, I'll go and leave comments in the code. Not that me dotting some i's is more important than you actually writing documentation.

By the way, Peter wrote, "now that we have 0-9-stable, I'd like for all applicable commits to go there first. 0-9-stable will then be merged into master." Your branch applies cleanly on 0-9-stable, so perhaps you could just retarget the pull request at it.

Contributor

joliss commented May 24, 2012

Since you asked, I'll go and leave comments in the code. Not that me dotting some i's is more important than you actually writing documentation.

By the way, Peter wrote, "now that we have 0-9-stable, I'd like for all applicable commits to go there first. 0-9-stable will then be merged into master." Your branch applies cleanly on 0-9-stable, so perhaps you could just retarget the pull request at it.

-
- They must also return the transformed value.
+ Adds the specified transform to the array of transform functions for this Binding.
+

This comment has been minimized.

Show comment Hide comment
@joliss

joliss May 24, 2012

Contributor

You're having trailing whitespace here. With the color.diff setting enabled, git diff should complain about trailing whitespace in garish red. To fix it, you could delete all \s+$

@joliss

joliss May 24, 2012

Contributor

You're having trailing whitespace here. With the color.diff setting enabled, git diff should complain about trailing whitespace in garish red. To fix it, you could delete all \s+$

@joliss

View changes

packages/ember-metal/lib/binding.js
+ A transform can be either a single function or an hash with `to` and `from` properties
+ that are each transform functions. If a single function is provided it will be set as the `to` transform.
+
+ Transform functions accept the value to be transfromed as their first argument and

This comment has been minimized.

Show comment Hide comment
@joliss

joliss May 24, 2012

Contributor

There!! I spotted a tyop (transfromed). Also "8value" below.

@joliss

joliss May 24, 2012

Contributor

There!! I spotted a tyop (transfromed). Also "8value" below.

@joliss

This comment has been minimized.

Show comment Hide comment
@joliss

joliss May 24, 2012

Contributor

... and whatever else I find, I'll just go fix it myself when I get around to reading your docs. I feel like I'm bike-shedding, complaining about typos here. Let's get this merged.

Your indentation looks impeccable, for what it's worth. :-)

Contributor

joliss commented May 24, 2012

... and whatever else I find, I'll just go fix it myself when I get around to reading your docs. I feel like I'm bike-shedding, complaining about typos here. Let's get this merged.

Your indentation looks impeccable, for what it's worth. :-)

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 24, 2012

This pull request fails (merged b419ab65 into 690e840).

This pull request fails (merged b419ab65 into 690e840).

@trek

This comment has been minimized.

Show comment Hide comment
@trek

trek May 24, 2012

Member

Not at all! I ask people to read them all and usually just get "cool, looks good bro" and then I end up finding typo and formatting errors myself weeks later. Lazy ingrates, the internet.

Member

trek commented May 24, 2012

Not at all! I ask people to read them all and usually just get "cool, looks good bro" and then I end up finding typo and formatting errors myself weeks later. Lazy ingrates, the internet.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 24, 2012

This pull request passes (merged 568f8ea into 2ec0dfa).

This pull request passes (merged 568f8ea into 2ec0dfa).

wycats added a commit that referenced this pull request May 25, 2012

Merge pull request #876 from trek/DocumentationForBindings
Additional Ember.Binding documentation.

@wycats wycats merged commit 8473cff into emberjs:master May 25, 2012

@wagenet

This comment has been minimized.

Show comment Hide comment
@wagenet

wagenet May 25, 2012

Member

@trek, @wycats Next time, can you send PRs like this to 0-9-stable? Everything in 0-9-stable will make it into master eventually.

Member

wagenet commented May 25, 2012

@trek, @wycats Next time, can you send PRs like this to 0-9-stable? Everything in 0-9-stable will make it into master eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment