GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No description provided.
Initial pushState based location implementation
Finaly, in my opinion it should be called HistoryLocation and not HTML5Location...
HistoryLocation sounds good to me. Should the registered keyword also be history? Also, do you mean that I should split the implementations off from Location into separate files?
yes and yes :)
Splitting location implementations from Location
Adding popstate tests for history based location
This seems useful. Would be good for someone who has worked more with the new routing stuff to review though. @wycats, @tomdale?
@digitaltoad lastSetURL is not part of the public API, and shouldn't be necessary in the pushstate impl, I think?
Removing lastSetURL from setURL
Cleaning up in history location
This pull request passes (merged 78ff347 into 9676856).
This pull request passes (merged c34a042 into 9676856).
This pull request passes (merged 5e2eef5 into 9676856).
Merge pull request #945 from digitaltoad/feature/html5_location
Adding pushState based location implementation