New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic routes vs Static segments. #969

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bradleypriest
Member

bradleypriest commented Jun 7, 2012

Currently when I try and access a route which has multiple possibilities, it seems to always use dynamic segments.

posts: Ember.State.create({
   route: 'posts',

  new: Ember.State.create({
    route: 'new'
  }),

  post: Ember.State.create({
    route: ':post_id'
  })
})

/posts/new seems to currently match 'posts.post' with a post_id of new

I have attached a failing test, but I don't know where I'd start to look for a fix.

Cheers,
Brad

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jun 7, 2012

This pull request passes (merged ab4e963 into b26ae89).

travisbot commented Jun 7, 2012

This pull request passes (merged ab4e963 into b26ae89).

@bradleypriest

This comment has been minimized.

Show comment
Hide comment
@bradleypriest

bradleypriest Jun 7, 2012

Member

Hmm, if you click through it's actually failing, silly @travisbot

Member

bradleypriest commented Jun 7, 2012

Hmm, if you click through it's actually failing, silly @travisbot

@wycats

This comment has been minimized.

Show comment
Hide comment
@wycats

wycats Jun 8, 2012

Member

Good call :)

Member

wycats commented Jun 8, 2012

Good call :)

@bradleypriest

This comment has been minimized.

Show comment
Hide comment
@bradleypriest
Member

bradleypriest commented Jun 21, 2012

Fixed by 2d26a36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment