Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ESNext #9731

Closed
wants to merge 1 commit into from

Conversation

@seanpdoyle
Copy link
Contributor

commented Nov 26, 2014

Since ember-cli includes esnext by default, we could also use new ES6
language features.

Add Support for ESNext
Since `ember-cli` includes `esnext` by default, we could also use new
ES6 language features.

@seanpdoyle seanpdoyle force-pushed the seanpdoyle:broccoli-esnext branch to 47cefba Nov 26, 2014

@rwjblue

This comment has been minimized.

Copy link
Member

commented Nov 26, 2014

I like it, but I have a couple concerns:

  • performance impact on each rebuild will be higher (it is already > 6s for rebuilds on production builds)
  • Possible issues with ESNext output in older browsers

The second can be confirmed with a simple check, the first is going to take a bit of time trialing to see how much slower it is for initial build and rebuilds for both dev builds (ember serve) and prod builds (ember serve --environment=production).

@seanpdoyle

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2014

Also, there is a problem with

module RSVP from 'rsvp';

It blows up from an ESNext perspective (this is the only issue I've seen thus far, there could be more)

There is a newer (0.9.5) version of the e6-module-transpiler that supports the import * as RSVP from "rsvp"; syntax (esnext/es6-module-transpiler#119 (comment)).

Does it make sense bumping the es6 transpiler version?

@rwjblue

This comment has been minimized.

Copy link
Member

commented Nov 26, 2014

It is not valid ES6 (which I knew when I added it), but we are not using the latest transpiler so we cannot use the current syntax.

Bumping the transpiler version is a massive task as it was completely re-written between 0.4 and 0.5 (it now supports a very nice bundled format that removes our loader issues also). There is another issue here that is tracking that update (might want to check it out for status).

@seanpdoyle

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2014

Thanks!

Sounds like this is a no-go given the current transpilation setup. I'll circle back in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.