New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer `import` over global `Ember.FOO` #9778

Merged
merged 1 commit into from Dec 3, 2014

Conversation

Projects
None yet
3 participants
@seanpdoyle
Contributor

seanpdoyle commented Dec 2, 2014

Import dependencies in tests, instead of reaching into global Ember
junk-drawer.

@stefanpenner

This comment has been minimized.

Member

stefanpenner commented Dec 2, 2014

👍

@seanpdoyle seanpdoyle force-pushed the seanpdoyle:es6-imports-in-ember-metal-tests branch 4 times, most recently Dec 2, 2014

Prefer `import` over global `Ember.FOO`
Import dependencies in tests, instead of reaching into global `Ember`
junk-drawer.

@seanpdoyle seanpdoyle force-pushed the seanpdoyle:es6-imports-in-ember-metal-tests branch to 8b3946c Dec 2, 2014

fivetanley added a commit that referenced this pull request Dec 3, 2014

Merge pull request #9778 from seanpdoyle/es6-imports-in-ember-metal-t…
…ests

Prefer `import` over global `Ember.FOO`

@fivetanley fivetanley merged commit ba79d64 into emberjs:master Dec 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@fivetanley

This comment has been minimized.

Member

fivetanley commented Dec 3, 2014

thanks! 👍

@seanpdoyle seanpdoyle deleted the seanpdoyle:es6-imports-in-ember-metal-tests branch Dec 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment