New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate `props_helper` module #9781

Merged
merged 1 commit into from Dec 3, 2014

Conversation

Projects
None yet
3 participants
@seanpdoyle
Contributor

seanpdoyle commented Dec 2, 2014

Utilize the more full-fledged ember-runtime/tests/props_helper module
instead.

@rwjblue

This comment has been minimized.

Member

rwjblue commented Dec 2, 2014

ember-metal should not have dependencies on ember-runtime (take a look at lib/packages.js for the package dependencies) , can you move the runtime props_helper into metal?

@seanpdoyle seanpdoyle force-pushed the seanpdoyle:props-helper-cleanup branch 2 times, most recently Dec 2, 2014

@seanpdoyle

This comment has been minimized.

Contributor

seanpdoyle commented Dec 2, 2014

@rwjblue this is ready for another look.

@rwjblue

This comment has been minimized.

Member

rwjblue commented Dec 2, 2014

Can you delete the now duplicated ember-runtime/tests/props_helper.js (or maybe you did and I missed it)?

@rwjblue

This comment has been minimized.

Member

rwjblue commented Dec 2, 2014

I realize I was a bit cryptic before: ember-metal cannot depend on ember-runtime, but ember-runtime CAN and does depend on ember-metal.

Remove duplicate `props_helper` module
Utilize the more full-fledged `ember-runtime/tests/props_helper` module
instead.

@seanpdoyle seanpdoyle force-pushed the seanpdoyle:props-helper-cleanup branch to 80be0ac Dec 2, 2014

@seanpdoyle

This comment has been minimized.

Contributor

seanpdoyle commented Dec 2, 2014

@rwjblue you're right, I forgot to remove the duplicate file. Should be good to go now.

@seanpdoyle

This comment has been minimized.

Contributor

seanpdoyle commented Dec 2, 2014

@rwjblue this is (once again, sorry) ready for another look.

stefanpenner added a commit that referenced this pull request Dec 3, 2014

Merge pull request #9781 from seanpdoyle/props-helper-cleanup
Remove duplicate `props_helper` module

@stefanpenner stefanpenner merged commit c2d51ea into emberjs:master Dec 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@stefanpenner

This comment has been minimized.

Member

stefanpenner commented Dec 3, 2014

woop thanks!

@seanpdoyle seanpdoyle deleted the seanpdoyle:props-helper-cleanup branch Dec 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment