Skip to content
This repository has been archived by the owner. It is now read-only.

Minor stuff I came across following the tutorial #2066

Merged
merged 5 commits into from Sep 18, 2017

Conversation

@adrianbw
Copy link
Contributor

commented Sep 18, 2017

autocomplete-component.md: in one example, the module and consts were switched.
hbs-helper.md: one example did have code addition/deletion that I believe it should have from seeing other examples.
service.md: The first use of camelize() really threw me when I was reading the docs, so I added a note about it.

@locks

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2017

Thank you for the tweaks, very appreciated!
I made a small tweak to service.md so it doesn't use the prototype extension. Hope that usage of the API is clear.

@locks locks merged commit 30a212e into emberjs:master Sep 18, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@adrianbw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2017

Sure, that works. I'd still like to put a note about those helpers under that first code sample. Thoughts?

@locks

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2017

@adrianbw are you on Slack? I'd like to chat on a higher-bandwidth medium.

@locks

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2017

We chatted on Slack and it opened the question of whether we even need/want to camelize, and it seems the answer is no. No code is better than no code!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.