This repository has been archived by the owner. It is now read-only.

[New Guide] Composing Components #66

Merged
merged 1 commit into from Jul 24, 2015

Conversation

Projects
None yet
10 participants
@knownasilya
Contributor

knownasilya commented Mar 19, 2015

So one of the biggest issues with components, is that users don't know how do use them, they are new and scary. This guide helps users dive into using components as they were meant to be used (beyond the single lonesome component).

This guide takes the Data Down and Actions Up approach that is being favored and will be prevalent once all of the Ember 2.0 component features are in (mut, attrs, etc).

preview rendered

@knownasilya knownasilya referenced this pull request Mar 23, 2015

Merged

RFC: Block params #3

@mgenev

This comment has been minimized.

Show comment
Hide comment
@mgenev

mgenev Mar 23, 2015

I'll review and make suggestions. Thanks for the link to this.

mgenev commented Mar 23, 2015

I'll review and make suggestions. Thanks for the link to this.

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Mar 25, 2015

Contributor

I think this is ready cc @rwjblue @trek

I can squash commits if you agree.

Contributor

knownasilya commented Mar 25, 2015

I think this is ready cc @rwjblue @trek

I can squash commits if you agree.

@knownasilya knownasilya changed the title from Composing Components to [New Guide] Composing Components Mar 27, 2015

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Mar 27, 2015

Contributor

Ping @trek

Contributor

knownasilya commented Mar 27, 2015

Ping @trek

@bf4

This comment has been minimized.

Show comment
Hide comment
@bf4

bf4 Jun 30, 2015

Seems like momentum on this PR has been lost...

bf4 commented Jun 30, 2015

Seems like momentum on this PR has been lost...

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jun 30, 2015

Contributor

@bf4 I think it's due to the fact that actions have changed in 1.13, so maybe a revision is in order.

Contributor

knownasilya commented Jun 30, 2015

@bf4 I think it's due to the fact that actions have changed in 1.13, so maybe a revision is in order.

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 10, 2015

Contributor

I'll try to tackle the changes this weekend. Would love for some people to be ready to check it once I have those in.

Contributor

knownasilya commented Jul 10, 2015

I'll try to tackle the changes this weekend. Would love for some people to be ready to check it once I have those in.

@locks

This comment has been minimized.

Show comment
Hide comment
@locks

locks Jul 12, 2015

Contributor

@knownasilya ping me if/when you do

Contributor

locks commented Jul 12, 2015

@knownasilya ping me if/when you do

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 12, 2015

Contributor

Already started, please review up until the CONTINUE HERE section.

Contributor

knownasilya commented Jul 12, 2015

Already started, please review up until the CONTINUE HERE section.

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 13, 2015

Contributor

Thanks for the comments! Will sort them out.

Contributor

knownasilya commented Jul 13, 2015

Thanks for the comments! Will sort them out.

@locks

This comment has been minimized.

Show comment
Hide comment
@locks

locks Jul 13, 2015

Contributor

Don't forget to rebase

Contributor

locks commented Jul 13, 2015

Don't forget to rebase

@michaelrkn

This comment has been minimized.

Show comment
Hide comment
@michaelrkn

michaelrkn Jul 22, 2015

Contributor

@knownasilya What do you think about @trek's suggestion to try to integrate this content into the rest of the pages in the Components section?

Contributor

michaelrkn commented Jul 22, 2015

@knownasilya What do you think about @trek's suggestion to try to integrate this content into the rest of the pages in the Components section?

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 22, 2015

Contributor

Sounds like it could be done, as long as we know what the TOC is for that section.

Contributor

knownasilya commented Jul 22, 2015

Sounds like it could be done, as long as we know what the TOC is for that section.

@michaelrkn

This comment has been minimized.

Show comment
Hide comment
@michaelrkn

michaelrkn Jul 22, 2015

Contributor

Yeah, that's a bit tough, because I imagine the Components section will have to be re-thought a bit when routable components lands. I'd lean towards just incorporating your ideas into the guides as they are now and not worry too much about the future, because the future is uncertain and your ideas are good :) But maybe I am not enough of a visionary. @trek, do you have any guidance here?

Contributor

michaelrkn commented Jul 22, 2015

Yeah, that's a bit tough, because I imagine the Components section will have to be re-thought a bit when routable components lands. I'd lean towards just incorporating your ideas into the guides as they are now and not worry too much about the future, because the future is uncertain and your ideas are good :) But maybe I am not enough of a visionary. @trek, do you have any guidance here?

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 23, 2015

Contributor

@mixonic thanks for the comments.

Contributor

knownasilya commented Jul 23, 2015

@mixonic thanks for the comments.

@mixonic

This comment has been minimized.

Show comment
Hide comment
@mixonic

mixonic Jul 23, 2015

Member

@knownasilya sorry this took me so long to look at. I am in theory 👍 on a merge if we get it polished up. @trek gets veto power if he wants to wait on an alternative TOC, but the worst that happens is that is gets refactored into that new TOC when it arrives IMO.

Member

mixonic commented Jul 23, 2015

@knownasilya sorry this took me so long to look at. I am in theory 👍 on a merge if we get it polished up. @trek gets veto power if he wants to wait on an alternative TOC, but the worst that happens is that is gets refactored into that new TOC when it arrives IMO.

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 23, 2015

Contributor

Will have a look at the comments and make the changes as soon as I can, hopefully tonight.

Contributor

knownasilya commented Jul 23, 2015

Will have a look at the comments and make the changes as soon as I can, hopefully tonight.

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya
Contributor

knownasilya commented Jul 23, 2015

To accomplish composability beyond simple templates, we need to pass data to those templates. This can be done with the `{{yield}}` helper that was introduced above.
The `{{yield}}` defines where the content we defined inside our component block will yield in the component's layout,
as we saw in the previous section. Apart from that, the yield helper also allows us to send data down by yielding params back to the scope the component was invoked in.

This comment has been minimized.

@mixonic

mixonic Jul 24, 2015

Member

as we saw in the previous section reads awkwardly.

@mixonic

mixonic Jul 24, 2015

Member

as we saw in the previous section reads awkwardly.

mixonic added a commit that referenced this pull request Jul 24, 2015

Merge pull request #66 from knownasilya/patch-1
[New Guide] Composing Components

@mixonic mixonic merged commit b02823a into emberjs:master Jul 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mixonic

This comment has been minimized.

Show comment
Hide comment
@mixonic

mixonic Jul 24, 2015

Member

👍 good improvements! Thanks for pushing on this.

Member

mixonic commented Jul 24, 2015

👍 good improvements! Thanks for pushing on this.

@locks

This comment has been minimized.

Show comment
Hide comment
@locks

locks Jul 24, 2015

Contributor

🍪 for you @knownasilya :) thanks

Contributor

locks commented Jul 24, 2015

🍪 for you @knownasilya :) thanks

@knownasilya knownasilya deleted the knownasilya:patch-1 branch Jul 24, 2015

@knownasilya

This comment has been minimized.

Show comment
Hide comment
@knownasilya

knownasilya Jul 24, 2015

Contributor

Thanks all for proof reading, couldn't have done it without you!

Contributor

knownasilya commented Jul 24, 2015

Thanks all for proof reading, couldn't have done it without you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.