From 72770afab057c32a0fe8e098e8e2ff9a93b2f774 Mon Sep 17 00:00:00 2001 From: wagenet Date: Wed, 23 Nov 2022 17:09:46 +0000 Subject: [PATCH 01/13] Advance RFC to Stage recommended --- text/0659-unique-id-helper.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/text/0659-unique-id-helper.md b/text/0659-unique-id-helper.md index 9c4db39d6b..2a30452adb 100644 --- a/text/0659-unique-id-helper.md +++ b/text/0659-unique-id-helper.md @@ -1,14 +1,13 @@ --- -stage: released # FIXME: This may be recommended +stage: recommended start-date: 2020-08-25T00:00:00.000Z release-date: 2022-05-02T00:00:00.000Z release-versions: ember-source: v4.4.0 - teams: - framework prs: - accepted: https://github.com/emberjs/rfcs/pull/659 + accepted: 'https://github.com/emberjs/rfcs/pull/659' project-link: --- From 38547cd19a10c28ae5c8f2773ed85a9d8637b141 Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Wed, 23 Nov 2022 17:09:51 +0000 Subject: [PATCH 02/13] Update RFC 0659 recommended PR URL --- text/0659-unique-id-helper.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/0659-unique-id-helper.md b/text/0659-unique-id-helper.md index 2a30452adb..ca333ec20f 100644 --- a/text/0659-unique-id-helper.md +++ b/text/0659-unique-id-helper.md @@ -8,6 +8,7 @@ teams: - framework prs: accepted: 'https://github.com/emberjs/rfcs/pull/659' + recommended: 'https://github.com/emberjs/rfcs/pull/865' project-link: --- From 7281eca4a6d519e3f619e491939f8879a5468a99 Mon Sep 17 00:00:00 2001 From: wagenet Date: Mon, 13 Mar 2023 19:55:07 +0000 Subject: [PATCH 03/13] Advance RFC {{ inputs.rfc-number }} to Stage recommended --- text/0776-typescript-blueprints.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/0776-typescript-blueprints.md b/text/0776-typescript-blueprints.md index 1daef59b51..26e393b6db 100644 --- a/text/0776-typescript-blueprints.md +++ b/text/0776-typescript-blueprints.md @@ -1,5 +1,5 @@ --- -stage: released +stage: recommended start-date: 2021-11-11T00:00:00.000Z release-date: 2022-12-08T00:00:00.000Z release-versions: From c0370fcf54ae6175be1f9279cee25606aa5baf77 Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Mon, 13 Mar 2023 19:55:11 +0000 Subject: [PATCH 04/13] Update RFC 0776 recommended PR URL --- text/0776-typescript-blueprints.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/0776-typescript-blueprints.md b/text/0776-typescript-blueprints.md index 26e393b6db..60ac50b269 100644 --- a/text/0776-typescript-blueprints.md +++ b/text/0776-typescript-blueprints.md @@ -12,6 +12,7 @@ prs: accepted: 'https://github.com/emberjs/rfcs/pull/776' ready-for-release: 'https://github.com/emberjs/rfcs/pull/873' released: 'https://github.com/emberjs/rfcs/pull/911' + recommended: 'https://github.com/emberjs/rfcs/pull/912' project-link: --- From b9c80ce199a7a4e5170193bbbe87773b00471181 Mon Sep 17 00:00:00 2001 From: wagenet Date: Sat, 10 Jun 2023 15:07:22 +0000 Subject: [PATCH 05/13] Advance RFC {{ inputs.rfc-number }} to Stage recommended --- text/0811-element-modifiers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/0811-element-modifiers.md b/text/0811-element-modifiers.md index 045eed0d5b..2611e069d9 100644 --- a/text/0811-element-modifiers.md +++ b/text/0811-element-modifiers.md @@ -1,5 +1,5 @@ --- -stage: released +stage: recommended start-date: 2022-03-29T00:00:00.000Z release-date: 2023-03-03T00:00:00.000Z release-versions: From f477635d20c887254b7923704543ad6eb6daa38f Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Sat, 10 Jun 2023 15:07:26 +0000 Subject: [PATCH 06/13] Update RFC 0811 recommended PR URL --- text/0811-element-modifiers.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/0811-element-modifiers.md b/text/0811-element-modifiers.md index 2611e069d9..3feac9cf67 100644 --- a/text/0811-element-modifiers.md +++ b/text/0811-element-modifiers.md @@ -11,6 +11,7 @@ prs: accepted: 'https://github.com/emberjs/rfcs/pull/811' ready-for-release: 'https://github.com/emberjs/rfcs/pull/885' released: 'https://github.com/emberjs/rfcs/pull/928' + recommended: 'https://github.com/emberjs/rfcs/pull/934' project-link: --- From 166023a2859c427a7f74ba2e0f7457c8b1486439 Mon Sep 17 00:00:00 2001 From: ef4 Date: Fri, 13 Oct 2023 18:05:36 +0000 Subject: [PATCH 07/13] Advance RFC 0918 to Stage released --- text/0918-deprecate-travis-ci-support.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/0918-deprecate-travis-ci-support.md b/text/0918-deprecate-travis-ci-support.md index 4770a27fad..888f276ce3 100644 --- a/text/0918-deprecate-travis-ci-support.md +++ b/text/0918-deprecate-travis-ci-support.md @@ -1,5 +1,5 @@ --- -stage: ready-for-release +stage: released start-date: 2023-03-25T00:00:00.000Z release-date: release-versions: From 6c6d6328411e3d5b1414651f029ed5f79527fda1 Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Fri, 13 Oct 2023 18:05:40 +0000 Subject: [PATCH 08/13] Update RFC 0918 released PR URL --- text/0918-deprecate-travis-ci-support.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/0918-deprecate-travis-ci-support.md b/text/0918-deprecate-travis-ci-support.md index 888f276ce3..9cf0ab20b3 100644 --- a/text/0918-deprecate-travis-ci-support.md +++ b/text/0918-deprecate-travis-ci-support.md @@ -9,6 +9,7 @@ teams: prs: accepted: 'https://github.com/emberjs/rfcs/pull/918' ready-for-release: 'https://github.com/emberjs/rfcs/pull/954' + released: 'https://github.com/emberjs/rfcs/pull/978' project-link: --- From 5cce5b2d6080493cf84b704e18db4292d5fda4ce Mon Sep 17 00:00:00 2001 From: Katie Gengler Date: Fri, 20 Oct 2023 13:29:26 -0400 Subject: [PATCH 09/13] Update Release versions and date --- text/0918-deprecate-travis-ci-support.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/text/0918-deprecate-travis-ci-support.md b/text/0918-deprecate-travis-ci-support.md index 9cf0ab20b3..168c55cda7 100644 --- a/text/0918-deprecate-travis-ci-support.md +++ b/text/0918-deprecate-travis-ci-support.md @@ -1,8 +1,9 @@ --- stage: released start-date: 2023-03-25T00:00:00.000Z -release-date: +release-date: 2023-12-11T00:00:00.000Z release-versions: + ember-cli: 5.5.0 teams: - cli - learning From cbe53de65265bcf02f2ee5e56b7a81be359eedcb Mon Sep 17 00:00:00 2001 From: ef4 Date: Fri, 15 Dec 2023 19:21:12 +0000 Subject: [PATCH 10/13] Advance RFC 0918 to Stage recommended --- text/0918-deprecate-travis-ci-support.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/0918-deprecate-travis-ci-support.md b/text/0918-deprecate-travis-ci-support.md index 168c55cda7..fdfb43d610 100644 --- a/text/0918-deprecate-travis-ci-support.md +++ b/text/0918-deprecate-travis-ci-support.md @@ -1,5 +1,5 @@ --- -stage: released +stage: recommended start-date: 2023-03-25T00:00:00.000Z release-date: 2023-12-11T00:00:00.000Z release-versions: From c66656224982100533070db95470f3952df06089 Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Fri, 15 Dec 2023 19:21:15 +0000 Subject: [PATCH 11/13] Update RFC 0918 recommended PR URL --- text/0918-deprecate-travis-ci-support.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/0918-deprecate-travis-ci-support.md b/text/0918-deprecate-travis-ci-support.md index fdfb43d610..0e1b69f241 100644 --- a/text/0918-deprecate-travis-ci-support.md +++ b/text/0918-deprecate-travis-ci-support.md @@ -11,6 +11,7 @@ prs: accepted: 'https://github.com/emberjs/rfcs/pull/918' ready-for-release: 'https://github.com/emberjs/rfcs/pull/954' released: 'https://github.com/emberjs/rfcs/pull/978' + recommended: 'https://github.com/emberjs/rfcs/pull/994' project-link: --- From 9b4cc2f4c5fe24f4ac626d6b9c7077d01915ce0a Mon Sep 17 00:00:00 2001 From: Katie Gengler Date: Fri, 12 Jan 2024 11:14:23 -0500 Subject: [PATCH 12/13] Update Ready for Release and Advance to Recommended PR templates to relfect more detailed criteria to remember --- .../advance-to-ready-for-release.md | 2 ++ .../advance-to-recommended.md | 22 +++++++++++++------ 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md b/.github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md index 390d88e2c3..e206fb9145 100644 --- a/.github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md +++ b/.github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md @@ -31,6 +31,8 @@ Each Ember core team will be requested as a reviewer on the PR to move into this - [ ] Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC - [ ] Any necessary learning materials have been updated - [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released. +- [ ] The feature may not yet have support by the entire ecosystem (e.g. IDEs, addons, Ember Inspector, Engines, Lint Rules, Blueprints, etc), but it does not unintentionally break any existing functionality in those areas. +- [ ] The Interactive Tutorial is not broken by this feature. - [ ] Criteria for moving to the Recommended Stage has been filled out - [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP - [ ] Each [team](https://github.com/emberjs/rfcs#relevant-teams) has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step. diff --git a/.github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md b/.github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md index 7f958b1507..bf0daf89b9 100644 --- a/.github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md +++ b/.github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md @@ -37,13 +37,21 @@ An FCP is required to enter this stage. Multiple RFCs may be moved as a batch in ## Checklist to move to Recommended -- [ ] Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met -- [ ] If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature. -- [ ] If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features. -- [ ] If the proposal updates or replaces an existing feature, high-quality codemods are available -- [ ] If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature. -- [ ] If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended". -- [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP +- [ ] **Criteria specific to this feature:** Any additional criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met. +- [ ] **Tutorial:** If appropriate, the feature is integrated into the tutorial. +- [ ] **Guides:** If appropriate, the feature is integrated into the guides prose. +- [ ] **API Docs:** API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature. +- [ ] **Addon Ecosystem:** If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features. +- [ ] **Codemods:** If the proposal updates or replaces an existing feature, high-quality codemods are available. +- [ ] **Debugging Tools:** If needed, Ember debugging tools (e.g. Ember Inspector, Deprecation Workflow) have been updated to support the feature. +- [ ] **IDE Support:** If needed, popular IDE support has been updated to support the feature. +- [ ] **Engines, SSR:** If needed, ecosystem feature such as Ember Engines, SSR support have been updated to support the feature. +- [ ] **Blueprints:** Blueprints have been updated to support the feature and to reflect the new best practices implied by this feature. +- [ ] **Linting:** Lint rules have been updated or added or removed to support the feature and to reflect the new best practices implied by this feature. +- [ ] **Deprecations:** If this feature implies that other features are no longer best practice, RFCs have been created to deprecate those features. +- [ ] **Blog Post:** Consider if a blog post should be written to introduce this feature to the community. +- [ ] **Feature Suite:** If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended". +- [ ] **FCP to Recommended:** This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP. ## Criteria for moving to Recommended (required) From a99d5e620f5246c0d59f7538c0383c7f9c426791 Mon Sep 17 00:00:00 2001 From: Katie Gengler Date: Fri, 12 Jan 2024 11:23:13 -0500 Subject: [PATCH 13/13] Update RFC template and Deprecation RFC template with some things to keep in mind --- 0000-template.md | 17 +++++++++++++++-- deprecation-template.md | 18 +++++++++++++++++- 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/0000-template.md b/0000-template.md index 73e1cf60f1..ddfaa7c758 100644 --- a/0000-template.md +++ b/0000-template.md @@ -30,7 +30,8 @@ project-link: Leave as is suite: Leave as is --> -# +<-- Replace "RFC title" with the title of your RFC --> +# RFC title ## Summary @@ -49,7 +50,17 @@ outcome? familiar with the framework to understand, and for somebody familiar with the implementation to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be -defined here. +defined here. + +> Please keep in mind any implications within the Ember ecosystem, such as: +> - Lint rules (ember-template-lint, eslint-plugin-ember) that should be added, modified or removed +> - Features that are replaced or made obsolete by this feature and should eventually be deprecated +> - Ember Inspector and debuggability +> - Server-side Rendering +> - Ember Engines +> - The Addon Ecosystem +> - IDE Support +> - Blueprints that should be added or modified ## How we teach this @@ -64,6 +75,8 @@ at any level? > How should this feature be introduced and taught to existing Ember users? +> Keep in mind the variety of learning materials: API docs, guides, blog posts, tutorials, etc. + ## Drawbacks > Why should we *not* do this? Please consider the impact on teaching Ember, diff --git a/deprecation-template.md b/deprecation-template.md index d86f0ae8d6..fcf280ae85 100644 --- a/deprecation-template.md +++ b/deprecation-template.md @@ -28,7 +28,8 @@ prs: project-link: Leave as is --> -# +<-- Replace "RFC title" with the title of your RFC --> +# RFC Title ## Summary @@ -47,6 +48,19 @@ Describe it in enough detail for someone who uses the deprecated functionality to understand, for someone to write the deprecation guide, and for someone familiar with the implementation to implement. +> It can be helpful to write the deprecation guide as part of this section. Published deprecation +> guides can be found at https://deprecations.emberjs.com/. + +> Please keep in mind any implications within the Ember ecosystem, such as: +> - Lint rules (ember-template-lint, eslint-plugin-ember) that should be added, modified or removed +> - Features that are replaced or made obsolete by this feature and should eventually be deprecated +> - Ember Inspector and debuggability +> - Server-side Rendering +> - Ember Engines +> - The Addon Ecosystem +> - IDE Support +> - Blueprints that should be added or modified + ## How We Teach This > Would the acceptance of this proposal mean the Ember guides must be @@ -58,6 +72,8 @@ related to this feature? How should this deprecation be introduced and explained to existing Ember users? +> Keep in mind the variety of learning materials: API docs, guides, blog posts, tutorials, etc. + ## Drawbacks > Why should we *not* do this? Please consider the impact on teaching Ember,