New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate component `eventManager` #194

Merged
merged 1 commit into from Mar 26, 2017

Conversation

Projects
None yet
4 participants
@GavinJoyce
Member

GavinJoyce commented Dec 26, 2016

@GavinJoyce GavinJoyce changed the title from Deprecate custom component `eventManager` to Deprecate component `eventManager` Dec 26, 2016

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Dec 26, 2016

Member

Awesome, thank you for putting this together!

We should also have this deprecation cover the canDispatchToEventManager property of EventDispatcher (mostly because the option does nothing at that point and is misleading) so that when this lands defining an eventManager on any component or specifying canDispatchToEventManager trigger a deprecation.

Member

rwjblue commented Dec 26, 2016

Awesome, thank you for putting this together!

We should also have this deprecation cover the canDispatchToEventManager property of EventDispatcher (mostly because the option does nothing at that point and is misleading) so that when this lands defining an eventManager on any component or specifying canDispatchToEventManager trigger a deprecation.

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Jan 17, 2017

I haven't used this feature before, but if I did, what would be the alternative to using it? (how do I un-deprecate my code)

kellyselden commented Jan 17, 2017

I haven't used this feature before, but if I did, what would be the alternative to using it? (how do I un-deprecate my code)

@GavinJoyce

This comment has been minimized.

Show comment
Hide comment
@GavinJoyce

GavinJoyce Jan 17, 2017

Member

@kellyselden you could extend EventDispatcher and implement the soon to be removed _findNearestEventManager in event handlers. I'm happy to create an addon for this if anyone requires it so that it's a simple opt-in.

Member

GavinJoyce commented Jan 17, 2017

@kellyselden you could extend EventDispatcher and implement the soon to be removed _findNearestEventManager in event handlers. I'm happy to create an addon for this if anyone requires it so that it's a simple opt-in.

true on `EventDispatcher`. The warning will have a target version of `3.0`.
If required, we can create an addon which extends the `EventDispatcher` allowing
for opt-in custom `eventManager`s in Ember apps.

This comment has been minimized.

@GavinJoyce

GavinJoyce Jan 17, 2017

Member

if anyone has a need for this, let me know and I'll create the addon

@GavinJoyce

GavinJoyce Jan 17, 2017

Member

if anyone has a need for this, let me know and I'll create the addon

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Jan 17, 2017

@GavinJoyce Addon route seems like a good idea to me.

kellyselden commented Jan 17, 2017

@GavinJoyce Addon route seems like a good idea to me.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jan 27, 2017

Member

Sorry for the delay here. We discussed in the core team meeting on 2017-01-20, and are 👍 on moving this to final comment period.

Member

rwjblue commented Jan 27, 2017

Sorry for the delay here. We discussed in the core team meeting on 2017-01-20, and are 👍 on moving this to final comment period.

@mixonic

This comment has been minimized.

Show comment
Hide comment
@mixonic

mixonic Mar 26, 2017

Member

I'm merging this, as we are certainly past the one-week window and I see no new comments 😗

Thank you!

Member

mixonic commented Mar 26, 2017

I'm merging this, as we are certainly past the one-week window and I see no new comments 😗

Thank you!

@mixonic mixonic merged commit 95a78b9 into emberjs:master Mar 26, 2017

@GavinJoyce GavinJoyce deleted the GavinJoyce:gj/deprecate-custom-event-mananger branch Jun 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment